search

ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
213 stars 52 forks source link

Fixes syntax errors when USE_MANUAL_MEMORY is undefined #3

Closed DurvalMenezes closed 10 months ago

DurvalMenezes commented 10 months ago

As per the title.

As discussed previously in the old Launchpad repo: https://bugs.launchpad.net/flashlight-firmware/+bug/2027884

And on BLF: https://budgetlightforum.com/t/ts10v2-ti-available-wurkkos-slender-waist-ts10-titanium-version-will-available-on-23th-sep/69700/1754

ToyKeeper commented 10 months ago

Thanks, I've probably missed several combinations of build options, and it's good to get those fixed. This fix was incomplete though, didn't compile when I tried it, so I finished it.

DurvalMenezes commented 10 months ago

You are welcome @Toykeeper, and thank you for accepting my PR. Interesting that github isn't showing any "finishes" to my changes (the indicated commit 76fd7e3 only shows changes to other files) which I interpret as this PR being incorporated as-is, but it's probably just me missing something.

EDIT: just found out what I was missing: https://github.com/ToyKeeper/anduril/commit/b43fc20617949458db4c1b562819a3b8f2757541; interestingly, these other changes you had to add weren't ever a problem here -- I mean, lacking them didn't generate any compile errors and did not generate any 'bad behaviors' from my lights. Anyway, glad to see the complete fix.