search

ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
199 stars 48 forks source link

thefreeman-avr32dd20-devkit has dubious model id #34

Closed gretel closed 7 months ago

gretel commented 7 months ago

https://github.com/ToyKeeper/anduril/blob/312f7442c31d72dd36f108de9542f81960526658/MODELS#L79

ToyKeeper commented 7 months ago

The model ID is intentional. I added support for hex digits in Version Check, to make it possible to use model numbers like this. The change also makes it possible to include git commit hash references in the version number.

gretel commented 7 months ago

maybe it's my lack of understanding but i don't see why it has to be done this way, or with any change to the actual codebase at all. i think the github actions way is in widespread use among similar projects because it can be very simple and therefore robust to have even complex and complicated release patterns reflected.