search

ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
199 stars 48 forks source link

Bugfix: Tactical mode has a dependency on momentary mode #46

Closed SiteRelEnby closed 4 months ago

SiteRelEnby commented 5 months ago

Use case 1: Updating a t85 light, where tactical mode is useful but takes some squeezing, and momentary is less useful

Use case 2: Custom builds for people who don't like/want momentary mode

Relys commented 4 months ago

Can I just have a moment here to vent that 5C for momentary mode is one of the single worst UX design choices I've ever seen? My partner and I routinely use 4C to put in pocket and whenever we accidently press the button once more we have to unscrew the battery.

I don't mind having a momentary mode option, but this mapping is just the worst.

SammysHP commented 4 months ago

Can I just have a moment here to vent

Uhm... Isn't that completely unrelated to this pull request?

SiteRelEnby commented 4 months ago

Technically yes, but it's a good example of a use case for this PR, which I agree with. I build firmware for my lights with tactical and without momentary as tactical gives me all the momentariness I need plus can be exited.

Relys commented 4 months ago

Technically yes, but it's a good example of a use case for this PR, which I agree with. I build firmware for my lights with tactical and without momentary as tactical gives me all the momentariness I need plus can be exited.

This would be perfect if I could use the autolock timer to go into tactical mode!!! It's really important having strobe in locked state incase you need to actual use it to defend yourself it should be mapped to same 3H.

ToyKeeper commented 4 months ago

Looking at the patch, it seems kind of incomplete. It looks like it would probably break strobes in Tactical Mode when Momentary Mode isn't enabled.

... okay, tested it. Doesn't work. So I fixed it.

I feel like there should probably be a cleaner way of handling all this, because the current method used for tactical mode, and for momentary strobes, is kludgy. But I'm not sure what solution would be better, so I'll leave it for now.

About Momentary on 5C, I would like to do something about it in the next "breaking UI changes" cycle... i.e. Anduril 3. It seems to be a common sentiment that I made momentary mode too easy to access, and most people don't ever want to use it, but they occasionally end up there by accident. So it should be harder to hit by accident. But I need to talk to the people who use it first, to make sure any changes still work for their needs.