search

ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
199 stars 48 forks source link

Feature/user customization #59

Closed crox closed 3 months ago

crox commented 3 months ago

I was testing this feature and had issues with the --user flag. I am not confident that I was using the feature correctly, but specifically the hex output contained an ending with the path such as:

mv: cannot move 'ui/anduril/anduril.hex' to 'hex/anduril.hank-noctigon-dm11-boost_users/crox.hex': No such file or directory

I attempted to add some basic error checking while here.

SiteRelEnby commented 3 months ago

Nice. For next time, if the creator of a PR is active, you can make a PR against their branch with their changes to incorporate them. I merged your branch into mine to keep working on it as I'd still like to update some of the documentation further too. Dhould probably mark mine as a draft as it's not 100% finished.

Thanks for the fix :)

crox commented 3 months ago

@SiteRelEnby thanks for the feedback. I will close this PR since you have pulled it in.