ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
213 stars 52 forks source link

Fix compile error when Simple UI is undefined. #6

Closed johnou closed 10 months ago

johnou commented 10 months ago

When removing Simple UI from the build there is a compiler error.

In file included from ui/anduril/anduril.c:197:0:
ui/anduril/channel-modes.c: In function ‘channel_mode_state’:
ui/anduril/channel-modes.c:133:5: error: expected expression before ‘else’
     else if (event == EV_click9_hold) {
     ^
ui/anduril/channel-modes.c:140:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
ERROR: build failed
johnou commented 10 months ago

@ToyKeeper guess I broke CI with the forward slash in my branch name :)

ToyKeeper commented 10 months ago

No, the slash is fine. I broke CI by ... not making it very robust. :sweat_smile:

Anyway, this seems like a much cleaner approach to fixing the issue, but I'm still changing some things before I merge it.

johnou commented 10 months ago

@ToyKeeper thanks!

gretel commented 10 months ago

users shouldn't be able to break the ci by choosing a branch name 🤓

ToyKeeper commented 10 months ago

users shouldn't be able to break the ci by choosing a branch name

I agree. So I took an unnecessary field out of the cache name. It was already more than unique enough without that.