ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
226 stars 56 forks source link

Bugfix: channel_mode for strobe->off, start on ramp #63

Open readableness opened 5 months ago

readableness commented 5 months ago

Fix channel_mode during smooth_steps operations. Maintain channel_mode until animation complete, restore ramp channel_mode before on.

Multichannel lights reverted to ramp channel_mode prior to actual off, unpleasantly mixing channels for some users during fade to off. Additionally, the ramp channel_mode would not always be restored before turning on, animating with the wrong channel_mode, then jumping to correct channel_mode at animation completion.

readableness commented 5 months ago

Updated commit to 4f5c8a3 to fix one more case - user interrupts off sequence/animation with a click to moon/on/turbo. This immediately restores the ramp channel_mode rather than wait to finish the turn on sequence/animation.

I believe this now covers all aspects of {strobe -> off -> ramp} that we can pull off: