minor fixes of the workflow to compile

ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit

GNU General Public License v3.0

213 stars 52 forks source link

minor fixes of the workflow to compile #7

Closed gretel closed 5 months ago

gretel commented 10 months ago

trigger on all 'push' and 'pull_request' events
fix workflow 'name' having spaces (used for artifact filename)
use GITHUB_REF_NAME to include branch/pr id in artifact filename

ToyKeeper commented 10 months ago

Running on all push/pull_request events seems like a good idea. It doesn't seem to need the ref name to guarantee a unique filename though, since it already has the revision hash and run number. Is there a reason that field would be needed?

gretel commented 10 months ago

Running on all push/pull_request events seems like a good idea. It doesn't seem to need the ref name to guarantee a unique filename though, since it already has the revision hash and run number. Is there a reason that field would be needed?

it's not a requirement.. just useful for reference; the downloaded file(name) has some basic semantics to figure back on the action it was resulting from.

ToyKeeper commented 5 months ago

Not really sure it needs the ref name in the file name. It has pros and cons though:

Pro: Makes collections of artifact files a bit easier to sort through. But I'm not aware of anyone in this project who actually does that, so I don't know of anyone who would see any benefits.
Con: Makes the process more brittle and prone to failing if users put anything unexpected in a text field.

So, closing for now unless there's a compelling reason to expand the filenames.