ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
199 stars 48 forks source link

Question: Button LED brightness when ramping #78

Open Mugrunty opened 2 months ago

Mugrunty commented 2 months ago

I've just recently updated my SP36 and SC21Pro to the latest version and noticed a change in behavior of the LED inside the buttons. On the previous Anduril 2.0 software (<=2023.2.11), the LED brightness when the flashlight was on would be DIM if using the current regulator and BRIGHT if starting to use the FET. Based on the brightness, it appears as though it no longer does this? It changes to BRIGHT far earlier in the ramp up process than before. I also thought that when you removed and replaced the battery, the default brightness would be 100% current regulator and 0% FET. This was what I used as my memory brightness, which was always just before the button LED would be BRIGHT if you were ramping up. It seems to default to a much lower brightness now? Did something change inadvertently when the lower moon mode and changes happened?? If anyone could clarify/define the new behavior of the button light, that would be great! Or...maybe this is an "unintentional feature"?

SiteRelEnby commented 2 months ago

The brightness change happens at DEFAULT_LEVEL, and AFAIK it hasn't previously had different logic, so possibly that was changed in those hwdefs. If you wanted one way to get the way you want would be to build with DEFAULT_LEVEL at maxreg (usually 130) and DEFAULT_MANUAL_MEMORY at your intended mem level.