ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
235 stars 57 forks source link

Bug: Voltage readout doesn't display correctly <1V (AA lights) #93

Open jan-Sanku opened 2 months ago

jan-Sanku commented 2 months ago

this probably only applies to the D3AA at the moment. low voltage cells below 1V don't display correctly in the voltage readout.

at the voltage i tested it, the light should've read out "098" (0.98V), but it only read out "98" with a slightly longer pause in the place of the zero. other zeroes are fine (1.00V read as "100" in the same test)

it's only a very minor issue, at this voltage LVP is already kicking in, so it's clear that the battery is nearly depleted.

tested on 0161-2023-12-03-38, hank's latest build i believe. i don't have a flashing adapter for the D3AA yet. i used a normal white eneloop AA.

SammysHP commented 2 months ago

I don't think this is a bug. Leading zeros are skipped in the current implement by design.

jan-Sanku commented 2 months ago

hm, i see. i think it's a bit strange to skip that zero though, it's not really "leading" if you consider there's a (implied) decimal point.

if it's not a bug, perhaps we can repurpose this issue into a feature suggestion?