search

ToyVo / nh_darwin

Yet another nix cli helper
European Union Public License 1.2
22 stars 5 forks source link

The binary should be named `nh` #14

Closed thecaralice closed 4 weeks ago

thecaralice commented 2 months ago

nh_darwin is fully compatible with nh, it is not a different project but just the original project with several patches, nh_darwin should not conflict with nh is these are not supposed to be installed together. Please rename to nh.

bestlem commented 2 months ago

The issue I think is that the original nh does run on macOS - it will manage home-manager at least. How do you differentiate the two?

thecaralice commented 2 months ago

I would differentiate between the packages, but why would I need to differentiate between the actual binaries if I only have one of them installed at any moment? Like GCC linker and LLVM linker are both /bin/ld despite having completely different implementations, and Vim xxd and standalone xxd are both /bin/xxd despite having different origins.

ToyVo commented 2 months ago

Originally it wasn't renamed but people wanted it.

https://github.com/ToyVo/nh_darwin/issues/6

Additionally if you use the modules provided by the flake you can enable programs.nh.alias to create a symlink to nh

thecaralice commented 2 months ago

Well I think the decision to rename the tool was rather rash and after reading both #6 and LnL7/nix-darwin#942 I still don't see any issue caused by nh_darwin binary being called nh.

ToyVo commented 2 months ago

I'm not disagreeing with you. Being that I did that change "rashly" I would appreciate anyone else chiming in so I don't make another rash decision.

thecaralice commented 2 months ago

I should note that this description is somewhat ironic

image
ToyVo commented 2 months ago

anybody who comes across this and would like to provide input please contribute here: https://github.com/ToyVo/nh_darwin/discussions/18 I am unsure of when I will end the poll, I can't imagine It'll get a ton of votes

ToyVo commented 4 weeks ago

Mentioned in the discussion but the results were in favor of putting the binary name back to nh, including my own preference. But the flake will have both a nh and a nh_darwin package defined, the nh_darwin will simply be a symlink to nh.