Tpatni719 / gsMAMS

GNU General Public License v3.0
0 stars 1 forks source link

JOSS Review: paper - statement of need #12

Closed njtierney closed 6 months ago

njtierney commented 7 months ago

Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?

The authors provide a great summary of the statement of need, but I think that this could be improved in a couple of ways.

Some packages that are available in R have limitations either in the number of treatment arms that can be incorporated in the package, the number of interim analyses that can be implemented in the package, or the different kinds of outcomes that the package can handle, but the MAMS package works well both for multiple treatment arms and multiple stages.

The authors should also state the target audience in this section.

Could the authors also describe why the package is named gsMAMS? What does the gs stand for? And for that matter, what does the MAMS stand for? Multiple Arm MS?

Tpatni719 commented 7 months ago

Thank you for the suggestions! The citation for MAMS is being provided in the summary itself and I have cited the other packages. I have also included the statement regarding target audience. And lastly, the gsMAMS is described in the summary itself. Please see the snapshot below: image

njtierney commented 7 months ago

Thanks! I note that you have a typo here: "satge" --> "stage"

I suggest adding (emphasis mine)

The R package, gdMAMS, which is an acronym, standing for: group sequential multi-arm multi-stage (MAMS) trials.

Tpatni123 commented 7 months ago

image

Regarding target audience

image

njtierney commented 6 months ago

Thanks!