search

Tpatni719 / gsMAMS

GNU General Public License v3.0
0 stars 1 forks source link

JOSS Review: paper - state of the field #13

Closed njtierney closed 6 months ago

njtierney commented 7 months ago

Do the authors describe how this software compares to other commonly-used packages?

They do! But I think that this could be improved a little bit. The authors state the following about MAMS:

But the computational effort of obtaining stopping boundaries is very high when the number of stages exceeds 3. This is the major hurdle of using MAMS package.

I think it would be beneficial to show one usage of the MAMS package or describe in more detail, perhaps using code, what the specific issues are - I note that the authors state:

To give an example, the computational time of MAMS package to obtain stopping boundaries and sample size of a multi-arm trial for continuous outcome with four experimental arms and three stages is around 7 minutes and for four stages is around 4.5 hours. But for gsMAMS package with same trial configuration, the computational time to obtain stopping boundaries and sample size for three stages and four stages design is around 0.06 seconds for both the cases.

Which is great! But it would be even better if they can demonstrate what the MAMS code looks like, compared to the gsMAMS code, and perhaps present these results they they have shown above in a table, to clearly demonstrate to the reader the advantage that gsMAMS provides?

Tpatni719 commented 7 months ago

I have added an example demonstration in the paper.

njtierney commented 7 months ago

When you respond to these issues on the paper could you please paste the content that you have added which addresses it, into the issue? This will save me needing to scour the paper to see where these changes were made. Thanks!

Tpatni123 commented 7 months ago

Sure!! image

njtierney commented 7 months ago

Thanks for this - would you be able to perhaps use comparable parameter values for the mams and design_cont functions?

Tpatni123 commented 7 months ago

I have used same trial configuration/parameters for both functions.

njtierney commented 7 months ago

Ah sorry it was hard to compare the code - could you add a sentence stating that the same equivalent parameters in each are used?

Tpatni719 commented 6 months ago

I have added the sentence.

njtierney commented 6 months ago

What sentence did you add? Can you please respond to comments with the additions that you made?

Tpatni123 commented 6 months ago

image

njtierney commented 6 months ago

OK great, thanks!