Tpatni719 / gsMAMS

GNU General Public License v3.0
0 stars 1 forks source link

set.seed( ) & results of example code #3

Closed RhysPeploe closed 6 months ago

RhysPeploe commented 6 months ago

https://github.com/openjournals/joss-reviews/issues/6322

My understanding is that these functions are deterministic, does the seed affect the results? If the seed does not imapct results, this can be removed?

It would be good to report the results you get from the code in the paper so that users can compare their results to those in the paper too

Tpatni719 commented 6 months ago

The design functions of the trial are indeed deterministic, but for generating the operating characteristics of the trial, we need the seed for reproducibility.

RhysPeploe commented 6 months ago

Ahh very well! Then I do not have concern with the seed. The results would be a good extra but that will not stop the checklist being completed - thanks