Tr4nter / auto-plant-crops-water

yvp
MIT License
0 stars 0 forks source link

crash when water hits crops #1

Open R0gyman opened 1 month ago

R0gyman commented 1 month ago

1.20.1 fabric glad to see that you've made a version that supports water, unfortunately for me it crashes when I try to use it

crash log 2024-10-16-2.log.gz

mod list modslist 2.txt

if there's anything I could do lmk

Tr4nter commented 1 month ago

https://github.com/Tr4nter/auto-plant-crops-water/releases/tag/AAAA it was crashing due to the mod was developed on a newer version, it should work on 1.20.1 now, lmk how it goes

R0gyman commented 1 month ago

okay now it doesn't crash but the mod doesn't work at all? if there is ANYTHING I can do lmk

Tr4nter commented 1 month ago

okay now it doesn't crash but the mod doesn't work at all? if there is ANYTHING I can do lmk

At all means.. the mod isnt loading and nothing is working even with the basic features or the water thing?

the mod works by setting a timer after the crop block has been destroyed by water, if the player isnt in range + the replacement of that block is still blocked by the time that timer has ended then replanting will be discarded

you could increase the timer by doing /maxPlantQueueHoldTime, the measurement is in ms

R0gyman commented 1 month ago

https://media3.giphy.com/media/v1.Y2lkPTc5MGI3NjExZGQ5NXZxdDFlZXd3MzVmeDFrOG1mYnJlcHdhaTE1NzZzMXM1bXh5NCZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/Uts8EDrT0tge0OgOBT/giphy.gif not sure if im doing anything wrong here am I not in range on this?

Tr4nter commented 1 month ago

https://media3.giphy.com/media/v1.Y2lkPTc5MGI3NjExZGQ5NXZxdDFlZXd3MzVmeDFrOG1mYnJlcHdhaTE1NzZzMXM1bXh5NCZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/Uts8EDrT0tge0OgOBT/giphy.gif not sure if im doing anything wrong here am I not in range on this?

You must have seed in your inventory and you have to be within 4.5 block radius of the farmland

R0gyman commented 1 month ago

https://media1.giphy.com/media/v1.Y2lkPTc5MGI3NjExZ3Rxc3h1bzMweGNyd2F5NWF0cG1pcWFmam83aWVxb2dncHUwZTgybiZlcD12MV9pbnRlcm5hbF9naWZfYnlfaWQmY3Q9Zw/wy580hNKMmwZAmtRYI/giphy.gif I tried it again and it still doesn't work with seeds in my hand standing on top ^^^

I also get a crash when exiting sometimes from the mod crash-2024-10-16_23.06.13-client.txt

Tr4nter commented 1 month ago

is it possible for you to send over the mod folder + world file?

R0gyman commented 1 month ago

is it possible for you to send over the mod folder + world file?

i got to pack my mods up anyways and i need to fix a couple of other bugs with my pack so ill try to find it before sending it ill send everything if i don't figure it out then, my modlist is in my original post

R0gyman commented 1 month ago

is it possible for you to send over the mod folder + world file? https://drive.google.com/file/d/1ufpmsNhO1PuoFJVL1PNiinCcxXgt4fi6/view?usp=sharing

Tr4nter commented 1 month ago

is it possible for you to send over the mod folder + world file? https://drive.google.com/file/d/1ufpmsNhO1PuoFJVL1PNiinCcxXgt4fi6/view?usp=sharing

Requested access

R0gyman commented 1 month ago

Requested access it should work now 👍 I have a sorted version of my mods if you want that instead

Tr4nter commented 1 month ago

Requested access it should work now 👍 I have a sorted version of my mods if you want that instead

I have tested it out and found the problem, the setting /maxPlantQueueHoldTime is too short (1ms), which means after the crop has been broken it will be removed from planting queue immediately, set it to a higher number and you should be fine

Tr4nter commented 1 month ago

Requested access it should work now 👍 I have a sorted version of my mods if you want that instead

I have tested it out and found the problem, the setting /maxPlantQueueHoldTime is too short (1ms), which means after the crop has been broken it will be removed from planting queue immediately, set it to a higher number and you should be fine

i have found the 5000-10000 range to be working quite well

R0gyman commented 1 month ago

i have found the 5000-10000 range to be working quite well

sorry I broke my Minecraft ill get back to u once I fix it