TrEE-TIMC / circhic

A python library to display HiC data on a circular strip and to integrate genomic data
https://tree-timc.github.io/circhic/
Other
1 stars 2 forks source link

_plot_raxis must be updated #40

Closed ijunier closed 4 years ago

ijunier commented 4 years ago

ccrescentuscirchic#2B.pdf

ijunier commented 4 years ago

Still bugging (cf figure)

ccrescentuscirchic#2.pdf

ijunier commented 4 years ago

Ticks work on 'distant' mode. But pb with tick labels as in 'reflect' mode

ccrescentuscirchic#3.pdf

NelleV commented 4 years ago

I think this is due to the resolution : if you provide inner_gdis and outer_gdis at the bin level, the code converts those in kb, which makes them below 0. Let's leave this open for now: we need a smarter conversion from unit to axis or just remove any conversion and let the user deal with it (as in "normal" matplotlib)

On Wed, 17 Jun 2020 at 13:32, ijunier notifications@github.com wrote:

Ticks work on 'distant' mode. But pb with tick labels as in 'reflect' mode

ccrescentuscirchic#3.pdf https://github.com/TrEE-TIMC/circhic/files/4792165/ccrescentus_circhic_.3.pdf

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/TrEE-TIMC/circhic/issues/40#issuecomment-645318878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNDXWRFRSLF2OKCRIO4PDRXCSTPANCNFSM4N5VGOAA .

NelleV commented 4 years ago

This is fixed: it doesn't do anything smart by default and assumes the user is going to specify ticklabels if it is not in the coordinate format. cf #52