TraGicCode / tragiccode-azure_key_vault

Pull secrets from Azure's key vault with this puppet module.
Apache License 2.0
6 stars 16 forks source link

(GH-65) Managed identity access token not being cached in hiera lookups #66

Closed dowlingw closed 3 years ago

dowlingw commented 3 years ago

Modifies lookup.rb to cache managed identity access token to resolve #65

TraGicCode commented 3 years ago

Hey @dowlingw,

Thank you for the Pull Request. Do you happen to know if a newer version of puppet changed/removed the methods i was originally using which caused the caching to be broken for you?

Thanks!

dowlingw commented 3 years ago

Puppet::LookupContext is still supported, but having a look through history it looks like the context.cache() was never implemented for the access token in lookup.rb, so from what I can see this has likely never been caching the access token.