search

TraGicCode / tragiccode-azure_key_vault

Pull secrets from Azure's key vault with this puppet module.
Apache License 2.0
6 stars 16 forks source link

Move API versions and default vault name to a configuration file #99

Closed sshipway closed 2 years ago

sshipway commented 2 years ago

It is awkward to have to specify the same API version on every function call.

Instead, why not have a configuration file ( such as puppet/azure.yaml ) on the puppetmaster, which can hold default values for the two API versions, and a default vault name, so that these do not have to be passed to every function call?

TraGicCode commented 2 years ago

Hey @sshipway ,

It is awkward to have to specify the same API version on every function call.

This was done in order to prevent hardcoding and allow the consumer of this puppet module the ability to specify whatever version they please.

Instead, why not have a configuration file ( such as puppet/azure.yaml ) on the puppetmaster, which can hold default values for the two API versions, and a default vault name, so that these do not have to be passed to every function call?

The initial idea would be people would be putting this in their hiera.yaml file and reuse this throughout their codebase which would require them to pass in the value, from hiera, to the function call.