Traben-0 / Entity_Model_Features

Other
90 stars 18 forks source link

[Bug - models] Root bone transformations with multiple models cause inconsistencies #144

Closed Thanos1716 closed 7 months ago

Thanos1716 commented 7 months ago

Bug description Whenever a root bone is transformed by an animation in a secondary model, the transformation also applies to the same root bone in the main model. If there are no entities rendered in the world that are using the secondary model, then the issue will not occur, (e.g /kill @e[type=minecraft:chicken], reload resources, and then /summon minecraft:chicken ~ ~ ~ will look fine) This seems to happen on all entities, but was not present in earlier versions of this mod.

Example resourcepack bugged-chickens.zip More model examples can be provided if necessary.

Screenshots Optifine: 2023-11-16_14 06 07

ETF + EMF (Adult chicken is scaled to 2x its normal size): 2023-11-16_14 07 30

Version information

Traben-0 commented 7 months ago

I have been made aware of this in part already

It would help me greatly if you could test 1 thing for me, assuming only 1 of these models is applying this scaling you've mentioned.

If you swap which model is the default and which is the variant (e.g. chicken2.jem) does it still occur?

It might take me several days if not a week to test further myself

Thanos1716 commented 7 months ago

Yes it appears to still occur when swapping them around Here is a screenshot: 2023-11-16_15 18 43

Thanos1716 commented 7 months ago

I believe this is related to #134

Traben-0 commented 7 months ago

i would agree i'll keep both for now to remind me to use both packs to test

Traben-0 commented 7 months ago

2023-11-25_16 21 42 fixed for next update