search

Traben-0 / Entity_Model_Features

Other
90 stars 18 forks source link

[Bug - models] Custom head models don't render in the inventory #150

Closed Thanos1716 closed 2 months ago

Thanos1716 commented 6 months ago

Bug Description When attempting to render any custom head model apart from the dragon head, notably only in item form, the game immediately crashes.

To Reproduce Steps to reproduce the behavior:

  1. Install this resourcepack example based on Mickey Joe's Barely Default
  2. Search for any broken mob head in the creative inventory (note the pack doesn't include a creeper head model)
  3. Observe crash

Expected behavior The game should not crash, and instead should render the correct custom model

Crashlog Can be found in the Discord

System

Traben-0 commented 6 months ago

I've identified the cause, and prevented the crash, this fix may affect texture overrides in skull blocks in inventory until I look into it further

Batcho001 commented 6 months ago

I don't know if I have the same issue as Thanos, but I am crashing because of the skeleton_skull item. In the crash log it mentions that it may be my immediately fast mod or gecko lib but I've already tried it without either of them and it still crashes. I found out that it only crashes with EMF enabled. Here is my crash log: crash-2023-12-22_14.44.26-client.txt

Traben-0 commented 6 months ago

Similar issue which I've also fixed for next update

Batcho001 commented 6 months ago

Your great man, thanks. I'll patiently wait for the next update and thanks for the quick reply.

GeekyBakerBen commented 6 months ago

Can confirm this only happens in the newest version so for anyone struggling with this crash while waiting on the next update, just roll back to the previous version for now and all should be ok.

Thanos1716 commented 6 months ago

This crash does seem to be fixed in 1.2.1, however I have noticed that piglin head ears don't seem to render.

Traben-0 commented 6 months ago

do they appear in optifine? i do notice optifine only names the head part of the piglin head block.

Thanos1716 commented 6 months ago

yeah they do appear in optifine with the same model, also if you power the head it makes the ears flap, maybe that has something to do with it?

Thanos1716 commented 4 months ago

Fixed in latest version :)

Thanos1716 commented 2 months ago

Oops my bad, this duplicates https://github.com/Traben-0/Entity_Model_Features/issues/193