Traben-0 / Entity_Model_Features

Other
90 stars 18 forks source link

[Bug] Incompatible with Embeddium #154

Closed Busyfox123 closed 6 months ago

Busyfox123 commented 6 months ago

Minecraft version:1.20.1 forge:47.2.0 [1.20.1] Embeddium 0.2.16 EMF] Entity Model Features[Forge 1.20.1] 1.1.0 Tested in environments with only Embeddium, EMF, and Oculus Wearing armor from other mods while using Embeddium can cause a significant decrease in frame rate When using a third person perspective or looking at other players, if the opponent is wearing armor, the frame rate will significantly decrease Deleting Embeddium will not cause this issue When the shader is not loaded, the frame rate will also be significantly reduced

test mod: Obscure API Aquamirae 6 API15 (1.20.1) twilightforest-1.20.1-4.3.1893-universal

spark: https://spark.lucko.me/Lb3B3zs2qX 基于Spark概要文件,滞后似乎来自EMF的代码。 2023-12-27_22 37 27 2023-12-27_22 37 43 2023-12-26_23 55 29 2023-12-26_23 55 45

kakashi1464 commented 6 months ago

tried without oculus?

TBlazeWarriorT commented 6 months ago

OH, so this is what was lagging me... Title is a bit misleading, I'd just call it laggy not incompatible

tried without oculus?

@kakashi1464 I just tried it too, still lags without oculus, which was expected since it was lagging without shaders too before fully disabling oculus I didn't try without Embeddium, but can confirm removing EMF massively improves my framerate from 15 FPS when looking at 8 armor stands to 150 FPS. It seems like when this bug is being triggered, your FPS gets roughly divided by the amount of armor sets on the screen... A single armor stand with modded armor takes me from 150 to 75, and vanilla armor doesn't lag

TBlazeWarriorT commented 6 months ago

Seems fixed in EMF 1.2.1 image