Closed Thanos1716 closed 3 months ago
this jem is cursed
the var.limb_swing one is because they used var.limb_swing instead of just limb_swing
and "var.water_counter" is declared twice which is the true cause of this issue
I will try and identify why it broke emf but that really should be fixed on the packs end as removing one of the duplicate "var.water_counter": "clamp(if(is_in_water,var.water_counter+0.05,var.water_counter-0.05),0,1)", declarations fixes it
hmm no its worse than that somehow that just makes it 0 for those parts
lol you're right, I didn't look too closely at the model when I reported this, but it is certainly a mess, if you can't find a simple fix I'll join their Discord and let the pack owner know
the simple fix is copy the chest boat
they'll want to wait until i update emf as they have other issues ive fixed
alright 👍🏼
there is some sort of strange jank going on here with the 2 of the same variable intersecting here and idk whats up with it
can you test for me what value the animations for paddle_left are reading from var.water_counter in optifine by wrapping it in a print?
sure, 1 sec
i need to know if it's flat 0 or if its actually reading the counter counting when in water
It does read the counter when in water
Started with a boat in water, then broke it and moved it onto land:
riding it into the water from the shoreline seems to have a transitional period that looks something like this, when printed every tick/frame (with an n of 1):
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.0
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.0
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.1
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.2
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.3
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.40000004
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.50000006
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.6000001
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.7000001
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.80000013
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 0.90000015
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 1.0
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 1.0
[14:12:49] [Render thread/INFO]: [OptiFine] CEM print(1) = 1.0
[14:12:50] [Render thread/INFO]: [OptiFine] CEM print(1) = 1.0
[14:12:50] [Render thread/INFO]: [OptiFine] CEM print(1) = 1.0
so its reading both variable declarations each frame
that makes some sense, but is also very cursed.
i'll see what i can do
[00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.0 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.1 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.2 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.3 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.40000004 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.50000006 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.6000001 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.7000001 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.80000013 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 0.90000015 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 1.0 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 1.0 [00:30:34] [Render thread/INFO]: [STDOUT]: EMF print: [1] = 1.0
even perfectly duplicating it seems to still be broken :/
i'm truly at a loss, i think the dev should just copy their chest boat animations
that is truly an impressive duplication
it is in a way :)
but then its also using the exact same values in the exact same way so its technically not surprising :/
I think it's the lined up floating point errors that make it really stand out
truly
It appears to be the entire boat now(?) according to that ↑ presumably the latest version, but I haven't checked.
For me, it is only normal boats spinning and not chest boats which is odd.
That is known This should be fixed pack-side for next release
They fixed it
Bug Description The boat model itself looks fine, but the
bottom_no_water
part spins around a bunch. This is in contrast to Optifine, and also interestingly the EMF chest boat model where thebottom_no_water
part stays in the bottom of the boat (this is animated similarly).List and link to broken resourcepacks https://modrinth.com/resourcepack/reimagined broken model (renamed to .json because Github doesn't support .jem): boat2.json Note: in this resourcepack, the boat.properties specifies to use boat2.jem always (except for cherry and bamboo boats)
Screenshots![2023-12-31_14 36 57](https://github.com/Traben-0/Entity_Model_Features/assets/80975570/a8ce51d2-c99b-4b28-ad32-8eaf09efd44c)
Log messages The following log messages are spammed ~15 times each resource reload
(please complete the following information):
Additional context Came across this issue when testing https://github.com/Traben-0/Entity_Texture_Features/issues/214
Tested with Optifine and it is in fact an Optifine parity issue for EMF This looks like it could be an easy fix considering the chest boat is working fine.