Traben-0 / Entity_Model_Features

Other
101 stars 17 forks source link

[Bug - models] Invisible chest minecart model. #232

Open ShadySalesGnome opened 3 months ago

ShadySalesGnome commented 3 months ago

Describe the bug Minecart with chest doesn't display unless a minecart with hopper is placed nearby, custom minecart model used on all minecart variants, minecart with chest is the only one that has this issue

Edit: issue changes slightly seemingly at random, sometimes placing a regular minecart also makes the minecart with chest display properly.

Edit 2: as of July 3rd Minecraft crashes whenever a chest minecart is placed or gets loaded in an existing chunk. Edit 3: after updating to 2.1.3 crashing problem is resolved, however the model still has the same issue it has in 2.0.3

List and link to broken resource packs

Doku's RPG https://modrinth.com/resourcepack/dokus-rpg

Gerudoku Faithful https://modrinth.com/resourcepack/gerudoku-faithful

Edit 4: Upon further inspection this seems to affect all resource packs containing a custom model for the chest minecart.

Expected behavior

2024-07-02_09 36 26

Screenshots 2024-07-02_09 37 50 2024-07-02_09 38 03 2024-07-02_09 38 12

(please complete the following information):

Update July 3rd:

Additional context I made this model for Gerudoku and Doku's RPG, the change to the model is a small one, just slightly alters the lower part of the cart.

fabric-loader version is 0.15.11-1.21 - 0.16.3-1.21.1

this bug occurs in single player worlds and on multiplayer servers.

after updating to 2.1.1 the game crashes and gives exit code -1

> The game crashed whilst rendering entity in world > Error: java.lang.NullPointerException: Cannot invoke "traben.entity_model_features.utils.EMFEntity.etf$isBlockEntity()" because the return value of "traben.entity_model_features.models.animation.EMFAnimationEntityContext.getEMFEntity()" is null

crash report: crash-2024-07-03_09.36.33-client.txt