[Bug - models] Chest Minecarts don't respond to animation argument "is_riding".

BaudMarch commented 4 months ago

Description When using "is_riding" in Blockbench animations, a minecart reacts accordingly, but a chest minecart doesn't.

Example : the following line should make it so a minecart riding another entity has its front bone made invisible: "front.visible": "if(is_riding,false,true)" it does work on minecarts, but not on chest minecarts (I tried making both models (minecart.json and chest_minecart.json). I tried with other attributes than visibility, such as scale, no luck. Chest minecarts still take other modifications, such as additional blocks. I didn't try other arguments or other special minecarts.

Version informations:

Minecraft Version: 1.20.5
EMF version 2.1.3
ETF version if applicable 6.1.3

BaudMarch commented 4 months ago

I actually gave it a CustomTile of "air" and that makes it work (in conjunction with the chest_minecart.json). Also works with a CustomTile of "tnt" so I'd bet it works as long as there is a CustomTile set.

BaudMarch commented 3 months ago

Upgraded my whole data-resource pack to 1.21, now the animation works, however it works no matter if the chest_minecart is riding an entity or not. Though again this time it seems to work as intented when a CustomDisplayTile is set that is not a chest variant. it appears as though the .visible parameter is always interpreted as false by default when mentioned in an animation. An example might be useful :

"front.visible":"if(is_riding,false,true)" should make it invisible when riding an entity living it visible by default, but it is invisible whether it rides an entity or not
"front.visible": "if(is_riding,true,false)" should do the opposite but stays invisible no matter what
"front.visible": "if(!is_riding,true,false)" should make it visible when NOT riding an entity and leave it invisible by default the rest of the time (which happens to be when it's riding an entity". It still is invisible no matter what

Hence why I think that the bug is that as long as .visible is used in animations, the specified bone will just be invisible by default in its default state, even if it's not what is specified in said animation. (Also tried with is_on_ground condition, seems to yield the same results unfortunately)

However, as previously, it works as intended for the normal minecart.

Traben-0 / Entity_Model_Features

[Bug - models] Chest Minecarts don't respond to animation argument "is_riding". #245