Traben-0 / Entity_Model_Features

Other
104 stars 18 forks source link

[Bug - models] CEM models sorted by folders do not work #255

Open PixalThePixeled opened 3 months ago

PixalThePixeled commented 3 months ago

In my resource pack there are many different random models for different mobs and I sorted them into folders as Optifine allows, for example “cem/armor_stand/armor_stand2.jem” and “cem/armor_stand/armor_stand.properties” (only the main model (armor_stand.jem) cannot be placed in the folder), but after updating EMF to 2.2 it doesn't work anymore. Models only work if random models and the properties file are in the "cem" folder, folders inside it do not work.

How it should look/How it looks in-game 2024-08-21_05 41 58

Traben-0 commented 3 months ago

Wait so armo_stand.jem is outside in a different folder to the properties and variants?

Does that really work on optifine? They should really be together in the folder

PixalThePixeled commented 3 months ago

In Optifine the base model only works in the "cem" folder, random models can be in the "cem/", and the properties files must be in the same folder along with the random models

Traben-0 commented 3 months ago

image optifine docs says it should work in the folder

Traben-0 commented 3 months ago

either way i've seen reports of this in another pack so i suppose ill bring this quirk back

DedMaxim commented 1 month ago

Can add some info about this issue. It does still work, actually, but only if the base model is also present in a subfolder. I'm making a modpack and I need a few custom models for named skeletons but there is also another resource pack that adds random models for mobs. Having skeleton.properties, skeleton2.jem and skeleton2.png in my resource pack/assets/minecraft/optifine/cem/skeleton doesn't work, named entity still uses random texture from a previous pack. But if I add any skeleton.jem into the same folder, where I have my named one, everything works! ...except random models from a previous pack, as now it gets overwritten by skeleton.jem in my pack... And, as a TS said, all works fine without regular jem file present using previous versions