[Bug - models] "Require base model for variation" is outdated and doesn't work properly (Optifine compatibility)

[magmamir]

Describe the bug
In the latest versions of Optifine, a base model for variations is only required if you don't have a .properties file. So it either need to have a base model or a .properties file to make variations work. In EMF, with the "Require base model - compatibility" option turned on (default settings), variations will only work if you have both, a base model and a .properties file. With the "Require base model - compatibility" option turned off, the base model is not mandatory, but the combination of base_model + variation2 + variation3 still won't work, unlike in Optifine.

To summarize:

In Optifine:

• model2 + model3 + model.properties will work
• base_model + model2 + model3 will work (a random model with equal chances is chosen, similar to how Random Entities work)
• model2 + model3 won't work
• base_model + model2 + model3 + model.properties will obviously work

In EMF (with "Require base model" enabled):

• base_model + model2 + model3 + model.properties will only work

In EMF (with "Require base model" disabled):

• model2 + model3 + model.properties will work
• base_model + model2 + model3 won't work
• base_model + model2 + model3 + model.properties will work

List and link to broken resourcepacks resources_end_test.zip

Expected behavior and Screenshots Optifine: EMF:

Versions:

• Minecraft Version: 1.21
• EMF version: 2.2.6
• ETF version: 6.2.4
• The only resource pack enabled was one attached above

[magmamir]

Checked OptiFine 1.20.1 HD U I6. Variations without base model still work.

[magmamir]

Fixed in 2.2.7 version. Thank you for the fix!