Traben-0 / Entity_Texture_Features

A Minecraft Fabric & Forge mod that adds random, emissive & blinking textures for mobs, skins and much more!
GNU Lesser General Public License v3.0
120 stars 22 forks source link

[BUG] ETF 4.3.0+ overrides modded boats' models #152

Closed SplendidAlakey closed 1 year ago

SplendidAlakey commented 1 year ago

Describe the issue

Some modded boats' models get overridden by the default oak boat, when ETF 4.3.0 or above is installed. For example Azalea and Jacaranda boats from Aurora's Decorations. Downgrading to 4.2.0 or lower solves the issue.

Screenshots

With ETF 4.3.3 2023-03-10_04 34 29

With ETF 4.2.0 2023-03-10_04 40 16

Logs

https://gist.github.com/SplendidAlakey/f0a7510157253309e4978b4024359fdf#file-latest_4-3-3-log

https://gist.github.com/SplendidAlakey/f0a7510157253309e4978b4024359fdf#file-latest_4-2-0-log

Your setup: (please complete the following information):

Traben-0 commented 1 year ago

strange, I will look into this

Traben-0 commented 1 year ago

i havent tested with the mentioned mod but i have redone the boat code so that it will respect any mods changes to this method in BoatEntityRenderer, which "should" be how most mod try and set new boat textures image

this fix will be in 4.3.5 when its out

Traben-0 commented 1 year ago

marking this as fixed, feel free to reopen if it breaks again