search

Traben-0 / Entity_Texture_Features

A Minecraft Fabric & Forge mod that adds random, emissive & blinking textures for mobs, skins and much more!
GNU Lesser General Public License v3.0
120 stars 22 forks source link

[BUG] Rendering glitch when looking at JER trading menu #201

Closed ffuentesm closed 6 months ago

ffuentesm commented 10 months ago

Describe the issue

When I check the trading menu from JER the rendering of the game stops. This means that things such as mobs, the player's hand, and any nonblock model turn invisible. I am not sure if this is an ETF or a JER issue, but this render glitch does not happen on other tabs that show villagers, nor does it happen to the wandering trader model. Without ETF and EMF the rendering works, the texture still missing, but the glitch does not happen.

Screenshots

image image image image image

Crash log

latest.log

Your setup: (please complete the following information):

Traben-0 commented 10 months ago

At a glance it seems like an issue with nbt trying to get read in a random model property, with those custom rendered villagers. Its likely something on etfs end not being null safe due to a value not usually being null in vanilla.

I'll look into it.

for now if you delete optifine/cem/villager.properties in FA they should all work again but you will lose the seperate villager sleeping animations

Traben-0 commented 8 months ago

can i get a version of the log where the render fails

this one is the one where it works but no textures with an error java.io.FileNotFoundException: minecraft:textures/entity/villager/profession/none.png

Traben-0 commented 8 months ago

specifically a log with ETF + EMF installed

ffuentesm commented 8 months ago

Here are the logs, both ETF and EMF are installed with FA, and both EMI trades and JER. For some reason, only the trading tab of JER causes the crash, while the EMI trades tab causes no such thing.

Event log: https://paste.gg/p/anonymous/3c88c73d0789489db7212802a128624c Latest Log: latest.log

Traben-0 commented 8 months ago

if you are on 1.20.2 the dev build i posted in my discord should fix this

it's just 1.20.2 for the moment until i'm ready to release then itll backport

Traben-0 commented 8 months ago

for the moment whatever emf model is trying to read villager nbt will cause this

any villager.properties file in optifine/cem using nbt will trigger this

Traben-0 commented 8 months ago

fresh animations for instance does it

ffuentesm commented 8 months ago

Well, I am on 1.20.1, as most of the mods I play are not yet being ported, since 1.20.3 is coming out soon. So it will take a while to see them updated. This is really strange, since EMI Trades also have the villager skin rendered with FA, and has no glitch or crash. While JER one does cause the crash.

As you can see, even JEP has no crash on the render. image

While just the JER tab causes the crash. image

Also, I think I have the same crash type when having the Villager item from Easy Villagers in a storage slot. Crash: https://bytebin.lucko.me/170FYHTxi1