Traben-0 / Entity_Texture_Features

A Minecraft Fabric & Forge mod that adds random, emissive & blinking textures for mobs, skins and much more!
GNU Lesser General Public License v3.0
126 stars 25 forks source link

Port to Forge 1.18.2 #51

Closed CanadianBaconBoi closed 2 years ago

CanadianBaconBoi commented 2 years ago

Ported this to forge 1.18.2 using Architectury loom.

Main change is not bundling cloth config as it is seen as better practice to keep them separated in Forge.

I would recommend creating a branch on the base repo called 'forge', I will change the PR branch when it is made.

Note. I had to remove the developer nametag easter egg as it caused issues with Applied Energistics

maximumpower55 commented 2 years ago

Thing to note is that there are major changes to the whole mod in dev right now

CanadianBaconBoi commented 2 years ago

If you'd like I could port that branch, or would it be preferable to wait for it to become stable?

maximumpower55 commented 2 years ago

If you'd like I could port that branch, or I could wait for it to become stable to port it.

You should wait for it to be in a stable state / release

Traben-0 commented 2 years ago

for now it might be easiest to just port from main yeah, i've made a forge branch for you

CanadianBaconBoi commented 2 years ago

Thank you, I've changed the base branch.

Traben-0 commented 2 years ago

the next release will have quite heavy reworks

maximumpower55 commented 2 years ago

for now it might be easiest to just port from main yeah, i've made a forge branch for you

The branch should be named architectury imo. But forge is fine

CanadianBaconBoi commented 2 years ago

I think that an architectury branch would be better suited for a mod with a common codebase that can compile to forge, fabric, and quilt.

Traben-0 commented 2 years ago

jsut made an Architectury one

maximumpower55 commented 2 years ago

I think that an architectury branch would be better suited for a mod with a common codebase that can compile to forge, fabric, and quilt.

Oh you didn't port it to a common codebase? That would make more sense imo

CanadianBaconBoi commented 2 years ago

@Traben-0 I could setup the Architectury branch for common builds

maximumpower55 commented 2 years ago

@Traben-0 I could setup the Architectury branch for common builds

I can help with porting it to a common codebase now that you have ported it to forge

CanadianBaconBoi commented 2 years ago

This was more of a quick port to forge from the existing codebase, it would make more sense for the dev branch to be developed for a common codebase as a design idea rather an afterthought though.

Traben-0 commented 2 years ago

it's going to be ideal for the future to have the common codebase

maximumpower55 commented 2 years ago

I would rather wait for anything more major to happen with this pr after the heavy reworks are in a stable state

CanadianBaconBoi commented 2 years ago

I would then refactor the dev branch with that design philosophy so there wouldn't have to be a seperate branch for a common codebase.

Traben-0 commented 2 years ago

we can just have the seperate forge version for now then

maximumpower55 commented 2 years ago

the next release will have quite heavy reworks

Aka #48