Closed CanadianBaconBoi closed 2 years ago
Thing to note is that there are major changes to the whole mod in dev right now
If you'd like I could port that branch, or would it be preferable to wait for it to become stable?
If you'd like I could port that branch, or I could wait for it to become stable to port it.
You should wait for it to be in a stable state / release
for now it might be easiest to just port from main yeah, i've made a forge branch for you
Thank you, I've changed the base branch.
the next release will have quite heavy reworks
for now it might be easiest to just port from main yeah, i've made a forge branch for you
The branch should be named architectury imo. But forge is fine
I think that an architectury branch would be better suited for a mod with a common codebase that can compile to forge, fabric, and quilt.
jsut made an Architectury one
I think that an architectury branch would be better suited for a mod with a common codebase that can compile to forge, fabric, and quilt.
Oh you didn't port it to a common codebase? That would make more sense imo
@Traben-0 I could setup the Architectury branch for common builds
@Traben-0 I could setup the Architectury branch for common builds
I can help with porting it to a common codebase now that you have ported it to forge
This was more of a quick port to forge from the existing codebase, it would make more sense for the dev branch to be developed for a common codebase as a design idea rather an afterthought though.
it's going to be ideal for the future to have the common codebase
I would rather wait for anything more major to happen with this pr after the heavy reworks are in a stable state
I would then refactor the dev branch with that design philosophy so there wouldn't have to be a seperate branch for a common codebase.
we can just have the seperate forge version for now then
the next release will have quite heavy reworks
Aka #48
Ported this to forge 1.18.2 using Architectury loom.
Main change is not bundling cloth config as it is seen as better practice to keep them separated in Forge.
I would recommend creating a branch on the base repo called 'forge', I will change the PR branch when it is made.
Note. I had to remove the developer nametag easter egg as it caused issues with Applied Energistics