Traben-0 / Entity_Texture_Features

A Minecraft Fabric & Forge mod that adds random, emissive & blinking textures for mobs, skins and much more!
GNU Lesser General Public License v3.0
126 stars 25 forks source link

entity spawned on soul sand or mud use default texture when using the blocks rule #73

Closed TheOnlyJoeEnderman closed 2 years ago

TheOnlyJoeEnderman commented 2 years ago

I think it's because they spawn 1/16 a block above the block or something 2022-06-19_11 58 06 2022-06-19_12 14 06 2022-06-19_12 14 12 2022-06-19_12 22 16 ?

I hope the images are helpful. I can copy and paste the properties file, but you can see everything else works. I set the texture to spawn on dirt for debug reasons.

TheOnlyJoeEnderman commented 2 years ago

This affects the latest two 1.19 releases of the mod. I haven't checked other versions.

Traben-0 commented 2 years ago

i'll look into this it is very much due the shortness of those blocks, i'm thinking I will extend the block check to check blocks they are inside of as well

Traben-0 commented 2 years ago

this fix will be in version 3.1.4 tonight

Traben-0 commented 2 years ago

the fixed version is uploaded now

TheOnlyJoeEnderman commented 2 years ago

Wow, that was fast.

TheOnlyJoeEnderman commented 2 years ago

Unfortunately the update did not fix the issue. I'll just work around that, since I don't need the block feature in this instance, biome will work fine. I can't think of any other times I'll need partial blocks for this feature.

Traben-0 commented 2 years ago

strange I am sure it worked in my testing, i will try and get this working again

TheOnlyJoeEnderman commented 2 years ago

I can provide pictures or video, but it's literally doing the same thing as the older version. At first I thought I put the wrong version in my mods folder, so I checked the curseforge page and it was the same version.

I had a theory that any bugfix you made might make entities spawned on lily pads think they spawned on water. But that wouldn't be the case if the reason entites were showing the wrong texture was because of a bug in Vanilla. I don't know what the code is doing under there, so I could be completely wrong about what's happening.

TheOnlyJoeEnderman commented 2 years ago

I accidentally closed it. Github on mobile is weird.

Traben-0 commented 2 years ago

what the code did was check the block directly below a mobs feet, this would round to the next lowest block if they were in a half/partial block like soulsand or lillies. I expanded the check to use the block its inside of too which would therefore count soulsand or lillies, I guess my testing was not thorough enough though, perhaps i spawned no ai mobs on the soulsand and they didn't fall into the partial block

Traben-0 commented 2 years ago

i'll update when i have a fix out

TheOnlyJoeEnderman commented 2 years ago

Thanks

Traben-0 commented 2 years ago

it was a small issue that was dependant on certain settings hence why it didn't affect my testing, it has been fixed in 4.0.beta.3 on curseforge, i will close this issue when its in a stable release

Traben-0 commented 2 years ago

fix in V4.0