search

Traben-0 / Entity_Texture_Features

A Minecraft Fabric & Forge mod that adds random, emissive & blinking textures for mobs, skins and much more!
GNU Lesser General Public License v3.0
122 stars 24 forks source link

[1.19] [Fabric] Unwanted enchanted pixels on the cape #84

Closed Precizne closed 2 years ago

Precizne commented 2 years ago

These 4 specific pixels(as per the screenshot) on the cape have enchantment glint on them even though that color isn't chosen in the skin file. Other pixels with the similar color do not have the glint on them. The pixels on the skin that are actually meant to have the glint are the eyes(which works). The eyes also use 2 tall blinking. This issue wasn't observed in 1.18.2 builds and only started with 1.19 builds. The cape type is minecraftcapes.net. 2022-07-14_01 35 19 2022-07-14_01 35 15

Traben-0 commented 2 years ago

i have a suspicion, are those enchanted pixels the same shape as your eyes, i can't tell from your image, they may possibly be applying the skin enchanted overlay onto the cape accidentally.

Can you please tell me the exact ETF version as well please, is it a dev build?

Precizne commented 2 years ago

This was not happening in any 1.18 builds prior to the first 1.19 release. I have not checked any 1.18 builds after that as I updated to 1.19. I have observed it from the first 3.1.0-1.19 version to the latest 3.1.4-1.19 version. It also exists on 4.0-dev9.

I also do think the enchanted overlay from the eyes are getting applied on the cape. Yes, they are the same shape as my eyes including the 2 pixel gap between the both (1 pixel on the edge and 1 pixel on the left of the enchanted pixels in the 2nd screenshot).

2022-07-18_17 47 55 2022-07-18_17 48 00

Traben-0 commented 2 years ago

I've found the issue, was a small logic error accidentally using the base player skin instead of the cape texture for the enchanted check. this will be in the next dev build on my discord, I will close this issue when it's on a stable build

Traben-0 commented 2 years ago

fix in V4.0