search

Traben-0 / Entity_Texture_Features

A Minecraft Fabric & Forge mod that adds random, emissive & blinking textures for mobs, skins and much more!
GNU Lesser General Public License v3.0
131 stars 25 forks source link

[1.19] [V4.0.1] [Fabric] Shield emissive textures kills FPS. #91

Closed kirmerk1 closed 2 years ago

kirmerk1 commented 2 years ago

When "Enable Optifine emissive entity textures" is "On" it reduces FPS depending on the number of resource packs enabled. No resource packs: ~200FPS 5 resource packs: ~140FPS 25 resource packs: ~40FPS Resource packs could be even for GUI only. Long loadings are due to 1.19 bug. Also forgot to mute the mic, sorry. https://www.youtube.com/watch?v=H5_l3cEk3Ns

Traben-0 commented 2 years ago

are there any errors in the log? i have an idea of how i might be able to alleviate this

kirmerk1 commented 2 years ago

latest.log Removed unnecessary mods. 25 recource packs log.

Traben-0 commented 2 years ago

entity_texture_features_fabric-4.0.2.beta.1.zip give this a go tell me if it helps

kirmerk1 commented 2 years ago

Sadly no. FPS a little bit better. 65 instead of 40, but without "emissive entity" I still have 240 UPD: FPS is better because I updated my GPU drivers. RX570 4GB if it helps. latest.log .

Traben-0 commented 2 years ago

i'm not getting the same kind of drop perhaps its the specific resourcepacks? can you install the spark profiler mod https://spark.lucko.me/ and run "/sparkc profiler" during the lag and after a few minutes run "/sparkc profiler --stop" it will give you a web url you can paste here and i can see exactly what code is causing the lag

also try this build entity_texture_features_fabric-4.0.2-GITHUBFIX.zip

kirmerk1 commented 2 years ago

No changes with new build. https://spark.lucko.me/4MwWHAHRyp Maybe you can reproduce it using the same map? https://www.planetminecraft.com/project/restworld-a-complete-resourcepack-testing-world-for-1-15-2/ Go to the shield/pattern room.

Traben-0 commented 2 years ago

i will give it a go tomorrow, is it specifically the shield pattern room only where this happens?

Traben-0 commented 2 years ago

does the issue go away if you disable shield emissive textures under special case emissive settings? perhaps it is a shield specific issue.

kirmerk1 commented 2 years ago

Yes, it helps. I disabled shield emissive textures and everything works fine. UPD: I should tell you about map earlier, sorry.

Traben-0 commented 2 years ago

all good mate these things happen, i will investigate this shield issue :) explains why I couldn't reproduce

Traben-0 commented 2 years ago

this should be greatly diminished in release 4.0.2 can you confirm?

kirmerk1 commented 2 years ago

Everything works fine. Thank you.