search

Traben-0 / flowing_fluids

Other
15 stars 0 forks source link

So many bugs #12

Open IAmREGE opened 2 weeks ago

IAmREGE commented 2 weeks ago

Bug 1: Command argument with Chinese characters?

See the image below Bug 1 image
Using tab to complete the command gives a true “关” instead of something like “off”.

Bug 2: Not all block placements could push the fluid

Slab block items are tested that their placements did not push the fluid(level != 8), they just replace it. Maybe all waterloggable block items?

Bug 3: Incorrect command description

/flowing_fluids settings appearance fluid_height outputs:


§7§o/flowing_fluids settings appearance fluid_height§r
Changes the heights fluids render at, currently set to BLOCK.
fluid_height is currently set to: block
§7_____________________________

But setting this item affects not only client rendering, entity behaviours are also affected(at least integrated server)!

IAmREGE commented 2 weeks ago

A possible solution of Bug 1 mentioned above:
In traben.flowing_fluids.config.FFCommands: Replace CommonComponents.OPTION_ON.getString().toLowerCase() with "on"; Replace CommonComponents.OPTION_OFF.getString().toLowerCase() with "off".

Traben-0 commented 2 weeks ago

I dont quite understand issue 2

i will adress issue 1 & 3 next update