TraceMachina / nativelink

🔥🔥🔥 Bazel RBE with CAS server implementation in Rust. The free and open source cache and remote execution service, prioritizing stability and speed for the people that need it.
https://docs.nativelink.com
Apache License 2.0
235 stars 46 forks source link

Move `update_action_with_internal_error` into `StateManager` #1053

Closed adam-singer closed 1 week ago

adam-singer commented 1 week ago

Description

worker_api_server.rs::WorkerApiServer::inner_execution_response contains the failure case/flow for action_stage: Result<ActionStage, Error> in WorkerStageManager::update_operation.

As of now that implementation is not handled when let action_stage = action_stage.expect("Unimplemented error in update_operation()"); is evaluated.

This ticket represents the need to refactor and consolidate that implementation into a single code path of update_action/update_operation.

Fixes https://github.com/TraceMachina/nativelink/issues/1054

Type of change

Please delete options that aren't relevant.

Checklist


This change is Reviewable