Join tasks if they are completed - Githubissues

TraceMachina / nativelink

NativeLink is an open source high-performance build cache and remote execution server, compatible with Bazel, Buck2, Reclient, and other RBE-compatible build systems. It offers drastically faster builds, reduced test flakiness, and specialized hardware.

https://nativelink.com

Apache License 2.0

1.14k stars 104 forks source link

Join tasks if they are completed #1079

Open zbirenbaum opened 3 months ago

zbirenbaum commented 3 months ago

Currently operations are only joined if they are not completed:

Two actions submitted prior to first's completion:

Client1: Execute Action(action_info)
Scheduler: Executing(operation_id(1))
Client2: Execute Action(same_action_info)
Scheduler: Executing(operation_id(1))
Scheduler: Completed(operation_id(1))

Action send after the first's completion:

Client: Execute Action(same_action_info)
Scheduler: Executing(operation_id(1))
Scheduler: Completed(operation_id(1))
Client: Execute Action(same_action_info)
Scheduler: Executing(operation_id(2))

This should instead be:

Client: Execute Action(same_action_info)
Scheduler: Executing(operation_id(1))
Scheduler: Completed(operation_id(1))
Client: Execute Action(same_action_info)
Scheduler: Completed (operation_id(1))

or:

Client: Execute Action(same_action_info)
Scheduler: Executing(operation_id(1))
Scheduler: Completed(operation_id(1))
Client: Execute Action(same_action_info)
Scheduler: Cache Check (operation_id(1))
Scheduler: Completed (operation_id(1))