Open leodziki opened 1 week ago
I would appreciate it if you could take a moment to review my pull request. Your feedback would be invaluable, and I’m particularly interested in any thoughts you have on the implementation and overall impact of the changes made. @blakehatch, @adam-singer
Thanks for your review
Hello, @aaronmondal Thank you for your review I will address this by splitting off my changes to serde_utils.rs into a separate PR and incorporating my test cases into the updated structure. Thank you for the feedback.
Update coverage rate of nativelink-config and nativelink-error to 80~100% Passed cargo test and bazel test
Description
Currently, coverage rate has been upgraded to 80-100% in nativelink-error and nativelink-config packages. Bazel test and cargo test both passed. And Pre-commit passed in direnv and everything is perfect. Fixed everything about the review
Fixes #1401
Type of change
How Has This Been Tested?
Bazel test, cargo test and pre-commit
Checklist
bazel test //...
passes locallyThis change is