TraceMachina / nativelink

NativeLink is an open source high-performance build cache and remote execution server, compatible with Bazel, Buck2, Reclient, and other RBE-compatible build systems. It offers drastically faster builds, reduced test flakiness, and specialized hardware.
https://nativelink.com
Apache License 2.0
1.2k stars 117 forks source link

We unintentionally depend on existing CAs during testtime and runtime #441

Open aaronmondal opened 12 months ago

aaronmondal commented 12 months ago

We're using hyper-rustls with the webpki-tokio feature enabled. The intention behind this is that we vendor the CA via webpki and make this explicitly extensible with custom CAs in the future.

Running the testsuite in an airgapped environment without a host CA shows that a bunch of tests fail (log is incomplete, these tests interrupt on error).

Logs ```bash native-link-nextest> Finished release [optimized] target(s) in 6m 28s native-link-nextest> Starting 237 tests across 38 binaries7: native-link-nextest> PASS [ 0.008s] native-link-scheduler::action_messages_test action_messages_tests::action_state_any_url_test native-link-nextest> PASS [ 0.008s] native-link-scheduler::action_messages_test action_messages_tests::equal_priority_earliest_first native-link-nextest> PASS [ 0.005s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::add_action_overwrites_property native-link-nextest> PASS [ 0.006s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::add_action_adds_property native-link-nextest> PASS [ 0.007s] native-link-scheduler::cache_lookup_scheduler_test cache_lookup_scheduler_tests::add_action_handles_skip_cache native-link-nextest> PASS [ 0.006s] native-link-scheduler::cache_lookup_scheduler_test cache_lookup_scheduler_tests::platform_property_manager_call_passed native-link-nextest> PASS [ 0.008s] native-link-scheduler::action_messages_test action_messages_tests::highest_priority_action_first native-link-nextest> PASS [ 0.006s] native-link-scheduler::cache_lookup_scheduler_test cache_lookup_scheduler_tests::find_existing_action_call_passed native-link-nextest> PASS [ 0.007s] native-link-scheduler::cache_lookup_scheduler_test cache_lookup_scheduler_tests::add_action_validates_outputs native-link-nextest> PASS [ 0.007s] native-link-scheduler::cache_lookup_scheduler_test cache_lookup_scheduler_tests::add_action_does_cache_lookup native-link-nextest> PASS [ 0.008s] native-link-scheduler::action_messages_test action_messages_tests::execute_response_status_message_is_some_on_success_test native-link-nextest> PASS [ 0.005s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::add_action_property_added_after_remov e native-link-nextest> PASS [ 0.005s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::add_action_property_remove native-link-nextest> PASS [ 0.005s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::add_action_property_remove_after_add native-link-nextest> PASS [ 0.004s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::find_existing_action_call_passed native-link-nextest> PASS [ 0.004s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::remove_adds_to_underlying_manager native-link-nextest> PASS [ 0.004s] native-link-scheduler::property_modifier_scheduler_test property_modifier_scheduler_tests::remove_retains_type_in_underlying_man ager native-link-nextest> PASS [ 0.009s] native-link-scheduler::simple_scheduler_test scheduler_tests::basic_add_action_with_one_worker_test native-link-nextest> PASS [ 0.008s] native-link-scheduler::simple_scheduler_test scheduler_tests::does_not_crash_if_operation_joined_then_relaunched native-link-nextest> PASS [ 0.009s] native-link-scheduler::simple_scheduler_test scheduler_tests::cacheable_items_join_same_action_queued_test native-link-nextest> PASS [ 0.008s] native-link-scheduler::simple_scheduler_test scheduler_tests::ensure_scheduler_drops_inner_spawn native-link-nextest> PASS [ 0.006s] native-link-scheduler::simple_scheduler_test scheduler_tests::run_two_jobs_on_same_worker_with_platform_properties_restrictions native-link-nextest> PASS [ 0.005s] native-link-scheduler::simple_scheduler_test scheduler_tests::update_action_sends_completed_result_after_disconnect native-link-nextest> PASS [ 0.005s] native-link-scheduler::simple_scheduler_test scheduler_tests::update_action_sends_completed_result_to_client_test native-link-nextest> PASS [ 0.008s] native-link-scheduler::simple_scheduler_test scheduler_tests::find_executing_action native-link-nextest> PASS [ 0.007s] native-link-scheduler::simple_scheduler_test scheduler_tests::remove_worker_reschedules_multiple_running_job_test native-link-nextest> PASS [ 0.007s] native-link-scheduler::simple_scheduler_test scheduler_tests::run_jobs_in_the_order_they_were_queued native-link-nextest> PASS [ 0.005s] native-link-scheduler::simple_scheduler_test scheduler_tests::worker_disconnects_does_not_schedule_for_execution_test native-link-nextest> PASS [ 0.004s] native-link-scheduler::simple_scheduler_test scheduler_tests::worker_retries_on_internal_error_and_fails_test native-link-nextest> PASS [ 0.005s] native-link-scheduler::simple_scheduler_test scheduler_tests::update_action_with_wrong_worker_id_errors_test native-link-nextest> PASS [ 0.004s] native-link-scheduler::simple_scheduler_test scheduler_tests::worker_should_not_queue_if_properties_dont_match_test native-link-nextest> PASS [ 0.010s] native-link-scheduler::simple_scheduler_test scheduler_tests::worker_timesout_reschedules_running_job_test native-link-nextest> PASS [ 0.010s] native-link-service::ac_server_test get_action_result::has_single_item native-link-nextest> PASS [ 0.009s] native-link-service::ac_server_test get_action_result::single_item_wrong_digest_size native-link-nextest> PASS [ 0.009s] native-link-service::bytestream_server_test query_tests::test_query_write_status_smoke_test native-link-nextest> PASS [ 0.010s] native-link-service::ac_server_test get_action_result::empty_store native-link-nextest> PASS [ 0.009s] native-link-service::ac_server_test update_action_result::one_item_update_test native-link-nextest> PASS [ 0.007s] native-link-service::bytestream_server_test write_tests::chunked_stream_receives_all_data native-link-nextest> PASS [ 0.008s] native-link-service::bytestream_server_test read_tests::read_with_not_found_does_not_deadlock native-link-nextest> PASS [ 0.008s] native-link-service::bytestream_server_test read_tests::chunked_stream_reads_small_set_of_data native-link-nextest> PASS [ 0.006s] native-link-service::bytestream_server_test write_tests::out_of_order_data_fails native-link-nextest> PASS [ 0.007s] native-link-service::bytestream_server_test write_tests::ensure_write_is_not_done_until_write_request_is_set native-link-nextest> PASS [ 0.006s] native-link-service::bytestream_server_test write_tests::resume_write_success native-link-nextest> PASS [ 0.005s] native-link-service::bytestream_server_test write_tests::upload_zero_byte_chunk native-link-nextest> PASS [ 0.005s] native-link-service::cas_server_test batch_read_blobs::batch_read_blobs_read_two_blobs_success_one_fail native-link-nextest> PASS [ 0.004s] native-link-service::worker_api_server_test keep_alive_tests::server_does_not_timeout_if_keep_alive_test native-link-nextest> PASS [ 0.009s] native-link-service::cas_server_test end_to_end::batch_update_blobs_two_items_existence_with_third_missing native-link-nextest> PASS [ 0.009s] native-link-service::cas_server_test batch_update_blobs::update_existing_item native-link-nextest> PASS [ 0.008s] native-link-service::cas_server_test find_missing_blobs::empty_store native-link-nextest> PASS [ 0.008s] native-link-service::cas_server_test find_missing_blobs::store_one_item_existence native-link-nextest> PASS [ 0.007s] native-link-service::worker_api_server_test connect_worker_tests::connect_worker_adds_worker_to_scheduler_test native-link-nextest> PASS [ 0.007s] native-link-service::worker_api_server_test execution_response_tests::execution_response_success_test native-link-nextest> PASS [ 0.008s] native-link-service::cas_server_test find_missing_blobs::has_three_requests_one_bad_hash native-link-nextest> PASS [ 0.005s] native-link-service::worker_api_server_test keep_alive_tests::server_times_out_workers_test native-link-nextest> PASS [ 0.007s] native-link-service::worker_api_server_test going_away_tests::going_away_removes_worker_test native-link-nextest> PASS [ 0.005s] native-link-service::worker_api_server_test keep_alive_tests::worker_receives_keep_alive_request_test native-link-nextest> PASS [ 0.005s] native-link-store::compression_store_test compression_store_tests::check_footer_test native-link-nextest> PASS [ 0.004s] native-link-store::compression_store_test compression_store_tests::check_header_test native-link-nextest> PASS [ 0.004s] native-link-store::compression_store_test compression_store_tests::sanity_check_zero_bytes_test native-link-nextest> PASS [ 0.011s] native-link-store::ac_utils_test ac_utils_tests::upload_file_to_store_with_large_file native-link-nextest> PASS [ 0.009s] native-link-store::compression_store_test compression_store_tests::simple_smoke_test native-link-nextest> PASS [ 0.008s] native-link-store::dedup_store_test dedup_store_tests::fetch_part_test native-link-nextest> PASS [ 0.005s] native-link-store::existence_store_test verify_store_tests::get_part_caches_if_exact_size_set native-link-nextest> PASS [ 0.007s] native-link-store::dedup_store_test dedup_store_tests::has_checks_content_store native-link-nextest> PASS [ 0.005s] native-link-store::existence_store_test verify_store_tests::update_flags_existance_cache_test native-link-nextest> PASS [ 0.005s] native-link-store::fast_slow_store_test fast_slow_store_tests::calculate_range_test native-link-nextest> PASS [ 0.006s] native-link-store::existence_store_test verify_store_tests::simple_exist_cache_test native-link-nextest> PASS [ 0.009s] native-link-store::dedup_store_test dedup_store_tests::has_with_no_existing_index_returns_none_test native-link-nextest> PASS [ 0.011s] native-link-store::dedup_store_test dedup_store_tests::check_length_not_set_with_chunk_read_beyond_first_chunk_regression_test native-link-nextest> PASS [ 0.008s] native-link-store::filesystem_store_test filesystem_store_tests::atime_updates_on_get_part_test native-link-nextest> PASS [ 0.013s] native-link-store::dedup_store_test dedup_store_tests::check_missing_last_chunk_test native-link-nextest> PASS [ 0.008s] native-link-store::filesystem_store_test filesystem_store_tests::digest_contents_replaced_continues_using_old_data native-link-nextest> PASS [ 0.007s] native-link-store::filesystem_store_test filesystem_store_tests::eviction_drops_file_test native-link-nextest> PASS [ 0.009s] native-link-store::fast_slow_store_test fast_slow_store_tests::partial_reads_copy_full_to_fast_store_test native-link-nextest> PASS [ 0.015s] native-link-store::compression_store_test compression_store_tests::partial_reads_test native-link-nextest> PASS [ 0.006s] native-link-store::filesystem_store_test filesystem_store_tests::eviction_on_insert_calls_unref_once native-link-nextest> PASS [ 0.012s] native-link-store::dedup_store_test dedup_store_tests::simple_round_trip_test native-link-nextest> PASS [ 0.010s] native-link-store::fast_slow_store_test fast_slow_store_tests::fetch_slow_store_puts_in_fast_store_test native-link-nextest> PASS [ 0.010s] native-link-store::filesystem_store_test filesystem_store_tests::file_continues_to_stream_on_content_replace_test native-link-nextest> PASS [ 0.008s] native-link-store::filesystem_store_test filesystem_store_tests::oldest_entry_evicted_with_access_times_loaded_from_disk native-link-nextest> PASS [ 0.009s] native-link-store::filesystem_store_test filesystem_store_tests::file_gets_cleans_up_on_cache_eviction native-link-nextest> PASS [ 0.005s] native-link-store::memory_store_test memory_store_tests::insert_one_item_then_update native-link-nextest> PASS [ 0.018s] native-link-store::dedup_store_test dedup_store_tests::check_chunk_boundary_reads_test native-link-nextest> PASS [ 0.005s] native-link-store::memory_store_test memory_store_tests::read_partial native-link-nextest> PASS [ 0.009s] native-link-store::filesystem_store_test filesystem_store_tests::rename_on_insert_fails_due_to_filesystem_error_proper_cleanup_h appens native-link-nextest> PASS [ 0.007s] native-link-store::memory_store_test memory_store_tests::ensure_full_copy_of_bytes_is_made_test native-link-nextest> PASS [ 0.008s] native-link-store::filesystem_store_test filesystem_store_tests::temp_files_get_deleted_on_replace_test native-link-nextest> PASS [ 0.005s] native-link-store::memory_store_test memory_store_tests::read_zero_size_item_test native-link-nextest> PASS [ 0.006s] native-link-store::memory_store_test memory_store_tests::errors_with_invalid_inputs native-link-nextest> PASS [ 0.007s] native-link-store::filesystem_store_test filesystem_store_tests::valid_results_after_shutdown_test native-link-nextest> PASS [ 0.010s] native-link-store::ref_store_test ref_store_tests::get_test native-link-nextest> PASS [ 0.009s] native-link-store::ref_store_test ref_store_tests::update_test native-link-nextest> FAIL [ 0.008s] native-link-store::s3_store_test s3_store_tests::get_part_simple_retries native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::get_part_simple_retries --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::get_part_simple_retries ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::get_part_simple_retries native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::get_part_simple_retries --- native-link-nextest> thread 's3_store_tests::get_part_simple_retries' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f257 7984ad5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> Canceling due to test failure: 21 tests still running1mpassed, 0 skipped native-link-nextest> PASS [ 0.009s] native-link-store::ref_store_test ref_store_tests::has_testmskipped native-link-nextest> FAIL [ 0.007s] native-link-store::s3_store_test s3_store_tests::simple_get_acipped native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::simple_get_ac --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::simple_get_ac ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::simple_get_ac native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::simple_get_ac --- native-link-nextest> thread 's3_store_tests::simple_get_ac' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab0 9ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> FAIL [ 0.007s] native-link-store::s3_store_test s3_store_tests::simple_has_object_found native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::simple_has_object_found --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::simple_has_object_found ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::simple_has_object_found native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::simple_has_object_found --- native-link-nextest> thread 's3_store_tests::simple_has_object_found' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f257 7984ad5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> FAIL [ 0.009s] native-link-store::s3_store_test s3_store_tests::simple_has_object_not_found[0m native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::simple_has_object_not_found --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::simple_has_object_not_found ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::simple_has_object_not_found native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::simple_has_object_not_found --- native-link-nextest> thread 's3_store_tests::simple_has_object_not_found' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89 f2577984ad5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> FAIL [ 0.011s] native-link-store::s3_store_test s3_store_tests::ensure_empty_string_in_stream_works_test native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::ensure_empty_string_in_stream_works_test --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::ensure_empty_string_in_stream_works_test ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::ensure_empty_string_in_stream_works_test native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::ensure_empty_string_in_stream_works_test --- native-link-nextest> thread 's3_store_tests::ensure_empty_string_in_stream_works_test' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b5 80ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> FAIL [ 0.007s] native-link-store::s3_store_test s3_store_tests::smoke_test_get_part[0m native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::smoke_test_get_part --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::smoke_test_get_part ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::smoke_test_get_part native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::smoke_test_get_part --- native-link-nextest> thread 's3_store_tests::smoke_test_get_part' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984 ad5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> FAIL [ 0.008s] native-link-store::s3_store_test s3_store_tests::simple_has_retries native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::simple_has_retries --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::simple_has_retries ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::simple_has_retries native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::simple_has_retries --- native-link-nextest> thread 's3_store_tests::simple_has_retries' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984a d5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> PASS [ 0.006s] native-link-store::shard_store_test shard_store_tests::has_with_many_digests_both_missing native-link-nextest> FAIL [ 0.008s] native-link-store::s3_store_test s3_store_tests::simple_update_aced native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::simple_update_ac --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::simple_update_ac ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::simple_update_ac native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.00s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::simple_update_ac --- native-link-nextest> thread 's3_store_tests::simple_update_ac' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5 ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> PASS [ 0.009s] native-link-store::shard_store_test shard_store_tests::get_part_reads_store0 native-link-nextest> PASS [ 0.008s] native-link-store::shard_store_test shard_store_tests::get_part_reads_store1 native-link-nextest> PASS [ 0.007s] native-link-store::shard_store_test shard_store_tests::has_with_many_digests_one_missing native-link-nextest> PASS [ 0.031s] native-link-store::compression_store_test compression_store_tests::rand_5mb_smoke_test native-link-nextest> PASS [ 0.007s] native-link-store::shard_store_test shard_store_tests::upload_download_has_check native-link-nextest> PASS [ 0.008s] native-link-store::shard_store_test shard_store_tests::has_with_one_digest native-link-nextest> PASS [ 0.005s] native-link-store::size_partitioning_store_test ref_store_tests::get_test native-link-nextest> PASS [ 0.008s] native-link-store::shard_store_test shard_store_tests::upload_store0[0m native-link-nextest> PASS [ 0.007s] native-link-store::shard_store_test shard_store_tests::weights_send_to_proper_store native-link-nextest> PASS [ 0.008s] native-link-store::shard_store_test shard_store_tests::upload_store1[0m native-link-nextest> PASS [ 0.045s] native-link-service::bytestream_server_test read_tests::chunked_stream_reads_10mb_of_data native-link-nextest> PASS [ 0.012s] native-link-store::shard_store_test shard_store_tests::has_with_many_digests_both_exist native-link-nextest> FAIL [ 0.041s] native-link-store::s3_store_test s3_store_tests::multipart_update_large_cas native-link-nextest> --- STDOUT: native-link-store::s3_store_test s3_store_tests::multipart_update_large_cas --- native-link-nextest> running 1 test native-link-nextest> test s3_store_tests::multipart_update_large_cas ... FAILED native-link-nextest> failures: native-link-nextest> failures: native-link-nextest> s3_store_tests::multipart_update_large_cas native-link-nextest> test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 8 filtered out; finished in 0.04s native-link-nextest> native-link-nextest> --- STDERR: native-link-store::s3_store_test s3_store_tests::multipart_update_large_cas --- native-link-nextest> thread 's3_store_tests::multipart_update_large_cas' panicked at /nix/store/q3fbizl2lhayaf3pnpnxksffp56c2bll-vendor-cargo-deps/c19b7c6f923b580ac259164a89f 2577984ad5ab09ee9d583b888f934adbbe8d0/hyper-rustls-0.24.2/src/config.rs:31:62: native-link-nextest> could not load platform certs: Os { code: 2, kind: NotFound, message: "No such file or directory" } native-link-nextest> note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace native-link-nextest> native-link-nextest> PASS [ 0.068s] native-link-store::fast_slow_store_test fast_slow_store_tests::write_large_amount_to_both_stores_test native-link-nextest> ------------[0m [ 00:00:00] [] 115/237: 1 running, 106 passed, 9 failed, 0 skipped native-link-nextest> Summary [ 0.099s] 116/237 tests run: 107 passed, 9 failed, 0 skipped native-link-nextest> FAIL [ 0.011s] native-link-store::s3_store_test s3_store_tests::ensure_empty_string_in_stream_works_test native-link-nextest> FAIL [ 0.008s] native-link-store::s3_store_test s3_store_tests::get_part_simple_retries native-link-nextest> FAIL [ 0.041s] native-link-store::s3_store_test s3_store_tests::multipart_update_large_cas native-link-nextest> FAIL [ 0.007s] native-link-store::s3_store_test s3_store_tests::simple_get_ac native-link-nextest> FAIL [ 0.007s] native-link-store::s3_store_test s3_store_tests::simple_has_object_found native-link-nextest> FAIL [ 0.009s] native-link-store::s3_store_test s3_store_tests::simple_has_object_not_found native-link-nextest> FAIL [ 0.008s] native-link-store::s3_store_test s3_store_tests::simple_has_retries native-link-nextest> FAIL [ 0.008s] native-link-store::s3_store_test s3_store_tests::simple_update_ac native-link-nextest> FAIL [ 0.007s] native-link-store::s3_store_test s3_store_tests::smoke_test_get_part native-link-nextest> error: test run failed6/237: 0 running, 107 passed, 9 failed, 0 skipped ```
allada commented 6 months ago

@aaronmondal, is this still valid?

MarcusSorealheis commented 2 weeks ago

@aaronmondal Ping again

aaronmondal commented 2 weeks ago

Still valid, although the scope has slightly changed. Some refs:

https://github.com/TraceMachina/nativelink/blob/545793c1899cb899c4b4239b83051a741621a9a0/nativelink-store/src/s3_store.rs#L148

https://github.com/TraceMachina/nativelink/blob/545793c1899cb899c4b4239b83051a741621a9a0/flake.nix#L163

It's currently unclear when and where we rely on vendored certs and when we rely on external certs.