Closed daryllimyt closed 1 month ago
Create new secrets module, inspired by this repo and this netflix repo
secrets
SecretService
Create get_session fastapi dependency
get_session
Standardize all creation endpoints to use POST. Some were still using PUT
Move db.converters to converters
db.converters
converters
Remove db.helpers - functionality was only used in tests, so moved there
db.helpers
Move test.integration.shared to test.shared, unit tests now using as well
test.integration.shared
test.shared
Don't return secret values in SecretResponse
SecretResponse
Refactor db.schemas to be as independent as possible
db.schemas
Simplify validation logic using sercrets service. Reduce usage of 'recursive' api calls from within an api request
Changes
Create new
secrets
module, inspired by this repo and this netflix repoSecretService
, which takes a sqlmodel session by dependency injection. This manages secretssecrets
. Auth and secrets are actually slightly different conceptsCreate
get_session
fastapi dependencyStandardize all creation endpoints to use POST. Some were still using PUT
Move
db.converters
toconverters
Remove
db.helpers
- functionality was only used in tests, so moved thereMove
test.integration.shared
totest.shared
, unit tests now using as wellDon't return secret values in
SecretResponse
Refactor
db.schemas
to be as independent as possibleSimplify validation logic using sercrets service. Reduce usage of 'recursive' api calls from within an api request
Fixes
Impact
db.schemas
in places that were previously not possible!Testing