search

TracecatHQ / tracecat

The open source Tines / Splunk SOAR alternative for security engineers.
https://tracecat.com
GNU Affero General Public License v3.0
2.42k stars 173 forks source link

feat+fix(integration): Check Point integration #504

Closed skrilab closed 2 weeks ago

skrilab commented 2 weeks ago

Description

This PR fixes:

This PR removes:

Related Tickets & Documents

This is an addition to Fix #501

Screenshots/Recordings

The error: Xnip2024-11-09_10-53-46

Steps to QA

  1. Create requered secret with keys
  2. Run
  3. Validate the output in the event result. Ensure there are no errors and that the token is present in the 'result' field.

[optional] What gif best describes this PR?

:)

Summary by CodeRabbit

topher-lo commented 2 weeks ago

@skrilab could we also name the namespace from integrations.checkpoint to integrations.check_point for consistency as well. Thanks for your suggestion for the name change!

skrilab commented 2 weeks ago

Yes, integrations.check_point makes sense!

coderabbitai[bot] commented 2 weeks ago

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

:label: Labels to auto review (1) * coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request include updates to the checkpoint.py file, where terminology is modified from "Checkpoint" to "Check Point," and a key is removed from the checkpoint_secret. Additionally, the get_auth_token function's response handling is adjusted. Two new actions, get_xdr_incidents and update_xdr_incident, are introduced in the integrations.check_point namespace, allowing for the retrieval and updating of Check Point Infinity XDR incidents.

Changes

File Path Change Summary
registry/tracecat_registry/integrations/checkpoint.py Updated terminology from "Checkpoint" to "Check Point," removed "CHECKPOINT_API_URL," and modified response handling in get_auth_token.
registry/tracecat_registry/templates/checkpoint/get_cp_xdr_incidents.yml Added new action get_xdr_incidents to retrieve Check Point Infinity XDR incidents.
registry/tracecat_registry/templates/checkpoint/update_cp_xdr_incident.yml Added new action update_xdr_incident to update incidents in Check Point Infinity XDR.

Assessment against linked issues

Objective Addressed Explanation
Fix incorrect secrets API usage in get token actions (#501) ❌ The change does not address the specified API usage issue.

🐇 In the meadow, bright and spry,
Check Point's name now reaches high!
With tokens fetched and incidents too,
Our actions dance, all fresh and new.
Hops of joy, let’s celebrate,
For changes made, oh, isn’t it great? 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
topher-lo commented 2 weeks ago

@skrilab please note that I've changed the namespace for the action as per our discussion above. This will cause breaking changes! You'll need to replace the actions in your "dev" environment with the new actions. Thanks!