Closed daryllimyt closed 1 week ago
The pull request introduces significant changes to the authentication configuration across multiple files. It removes specific admin user setup environment variables and adds new variables that enhance general authentication settings. Additionally, workflow configurations have been updated to allow manual execution, and error handling improvements have been made in user registration processes. These changes streamline the setup and management of authentication while enhancing error handling and flexibility in the application.
File | Change Summary |
---|---|
.env.example |
Removed TRACECAT__SETUP_ADMIN_EMAIL , TRACECAT__SETUP_ADMIN_PASSWORD ; added TRACECAT__AUTH_ALLOWED_DOMAINS , TRACECAT__AUTH_MIN_PASSWORD_LENGTH . |
.github/workflows/test-python.yml |
Added workflow_dispatch trigger; updated permissions; removed TRACECAT__SETUP_ADMIN_EMAIL and TRACECAT__SETUP_ADMIN_PASSWORD . |
docker-compose.dev.yml |
Added TRACECAT__AUTH_ALLOWED_DOMAINS , TRACECAT__AUTH_MIN_PASSWORD_LENGTH ; removed TRACECAT__SETUP_ADMIN_EMAIL , TRACECAT__SETUP_ADMIN_PASSWORD . |
docker-compose.yml |
Added TRACECAT__AUTH_ALLOWED_DOMAINS , TRACECAT__AUTH_MIN_PASSWORD_LENGTH ; removed TRACECAT__SETUP_ADMIN_EMAIL , TRACECAT__SETUP_ADMIN_PASSWORD . |
env.sh |
Removed user prompts for admin email and password; deleted password validation logic. |
frontend/src/components/auth/sign-up.tsx |
Enhanced error handling in BasicRegistrationForm for registration errors. |
tests/conftest.py |
Added TRACECAT__AUTH_ALLOWED_DOMAINS to env_sandbox ; updated test_admin_user fixture to use dynamic values. |
tracecat/api/app.py |
Added exception handler for FastAPIUsersException ; removed logic for creating default admin user. |
tracecat/auth/users.py |
Added InvalidDomainException ; enhanced user management with new validation methods. |
tracecat/config.py |
Added TRACECAT__AUTH_ALLOWED_DOMAINS and TRACECAT__AUTH_MIN_PASSWORD_LENGTH configuration variables. |
tracecat/registry/client.py |
Updated error handling in call_action method to check if detail is a mapping. |
pyproject.toml |
Added dependency email-validator with version constraint >=2.0.0 . |
docker-compose.dev.yml
and docker-compose.yml
files in PR #509, which also remove the same admin user setup variables and add new authentication settings.internal
, infrastructure
🐰 In the meadow where bunnies play,
New settings bloom, brightening the day.
Admin paths have faded away,
With domains and passwords, come what may!
Hop along, let errors be clear,
A joyful change, let’s give a cheer! 🌼
[!WARNING]
Rate limit exceeded
@daryllimyt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 25 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between 549735863c1f1a9486d7c1726fbc93d69c64fbb3 and 853739478a94caf2f99af7b18cfd3f8726ca0dce.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Changes
email-validator
)Screens
https://github.com/user-attachments/assets/6305dfa2-f92a-49f0-8610-d36414244ef1
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores
These changes enhance user experience and security while simplifying the setup process.