search

TrackableEntities / EntityFrameworkCore.Scaffolding.Handlebars

Scaffold EF Core models using Handlebars templates.
MIT License
208 stars 53 forks source link

Support for schema comments #117

Closed MarkAtRamp51 closed 4 years ago

MarkAtRamp51 commented 4 years ago

Proposed changes Two new handlebars tokens were added to allow for the use of {{comment}} on table templates and {{property-comment}} on property templates. This can be useful to incorporate database description metadata into XML doc comments on the models.

Related Issue There isn't an associated issue at this time.

MarkAtRamp51 commented 4 years ago

@tonysneed thanks for your patience. Give this a try, and let me know what needs an update.

tonysneed commented 4 years ago

@MarkAtRamp51 All the changes look good. I approve the PR. Do you want to perform Steps 16-17 in the Contributing Guidelines to squash your commits? If you don't succeed, or do not wish to perform the squash, just don't push your changes. Just let me know and I can do the squash from my side.

MarkAtRamp51 commented 4 years ago

Yes I'll do it. Thank you.

MarkAtRamp51 commented 4 years ago

@tonysneed I think it's good to go.

tonysneed commented 4 years ago

@MarkAtRamp51 You did the squash! Congratulations!

MarkAtRamp51 commented 4 years ago

@tonysneed Haha, yeah it was much easier than trying to squash and merge all those other commits. It definitely felt like a happy path "squash." I'm looking to be more active in a project so If you think there is anything you could use help on let me know. Thanks again for your support.

tonysneed commented 4 years ago

You passed the squash test. :) amA bit more advanced is rebasing on top of upstream commits. We can try that next time. And I’ll be very grateful for your help on other feature requests.