Private functions used in overridable methods?

[slymuffhugger]

Not sure if this qualifies as a "bug", but when attempting to override GenerateProperties by copy/pasting the existing code and modifying I'm met with the dreaded red squiggles because the original Method uses private properties and methods.. I can copy/paste those too, but if it ever changes I won't get those changes. Would it be better if they were public or internal?

[tonysneed]

Good questions. The private methods can probably be made protected.

Might make a good PR if you are interested. 😄

[slymuffhugger]

Haven't really contributed much before but I could give it a go 😃

[tonysneed]

Might make for a good first PR. See the contributing guidelines to how to get started.

[slymuffhugger]

Would we want all of _options accessible or would it be better just to make a protected property that accesses the one property within _options? And should it return false when _options is null? something like protected bool GenerateComments => _options?.Value?.GenerateComments ?? false;

[tonysneed]

Not a bad idea to make the options protected.