search

Trackage / trip

trip package development
http://trackage.github.io/trip/
12 stars 2 forks source link

split is broken? #34

Closed mdsumner closed 5 years ago

mdsumner commented 5 years ago

there's something funny, this should work as per https://github.com/Trackage/trip/issues/20

reprex::reprex({
  library(trip)
tr <- walrus818
mapgrid <- raster::raster(tr)
listofgrids <- lapply(split(tr, tr$Deployment), function(x) raster::rasterize(x, mapgrid))
raster::plot(raster::brick(listofgrids))
devtools::session_info()
})
mdsumner commented 5 years ago

Add an explicit split method, a copy of the SPDF one. 

``` r
library(trip)
setMethod("split", signature(x = "trip", f = "ANY"), 
          function(x, f, drop = FALSE, ...) {
              lapply(split(x = seq_len(nrow(x)), f = f, drop = drop, ...), 
                     function(ind) x[ind, , drop = FALSE])
          })
tr <- walrus818
mapgrid <- raster::raster(tr)
listofgrids <- lapply(split(walrus818, tr$Deployment), function(x) raster::rasterize(x, mapgrid))
raster::plot(raster::brick(listofgrids))

devtools::session_info()
#> ─ Session info ──────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.5.3 (2019-03-11)
#>  os       Ubuntu 18.04.2 LTS          
#>  system   x86_64, linux-gnu           
#>  ui       X11                         
#>  language (EN)                        
#>  collate  en_AU.UTF-8                 
#>  ctype    en_AU.UTF-8                 
#>  tz       Etc/UTC                     
#>  date     2019-04-13                  
#> 
#> ─ Packages ──────────────────────────────────────────────────────────────
#>  package        * version    date       lib
#>  abind            1.4-5      2016-07-21 [2]
#>  assertthat       0.2.1      2019-03-21 [2]
#>  backports        1.1.3      2018-12-14 [2]
#>  callr            3.2.0      2019-03-15 [2]
#>  cli              1.1.0      2019-03-19 [2]
#>  codetools        0.2-16     2018-12-24 [4]
#>  crayon           1.3.4      2017-09-16 [2]
#>  deldir           0.1-16     2019-01-04 [2]
#>  desc             1.2.0      2018-05-01 [2]
#>  devtools         2.0.2      2019-04-08 [2]
#>  digest           0.6.18     2018-10-10 [2]
#>  evaluate         0.13       2019-02-12 [2]
#>  foreign          0.8-71     2018-07-20 [4]
#>  fs               1.2.7      2019-03-19 [2]
#>  glue             1.3.1      2019-03-12 [2]
#>  goftest          1.1-1      2017-04-03 [2]
#>  highr            0.8        2019-03-20 [2]
#>  htmltools        0.3.6      2017-04-28 [2]
#>  knitr            1.22       2019-03-08 [2]
#>  lattice          0.20-38    2018-11-04 [4]
#>  magrittr         1.5        2014-11-22 [2]
#>  maptools         0.9-5      2019-02-18 [2]
#>  MASS             7.3-51.1   2018-11-01 [4]
#>  Matrix           1.2-17     2019-03-22 [4]
#>  memoise          1.1.0      2017-04-21 [2]
#>  mgcv             1.8-28     2019-03-21 [4]
#>  nlme             3.1-139    2019-04-09 [4]
#>  pkgbuild         1.0.3      2019-03-20 [2]
#>  pkgload          1.0.2      2018-10-29 [2]
#>  polyclip         1.10-0     2019-03-14 [2]
#>  prettyunits      1.0.2      2015-07-13 [2]
#>  processx         3.3.0      2019-03-10 [2]
#>  ps               1.3.0      2018-12-21 [2]
#>  R6               2.4.0      2019-02-14 [2]
#>  raster           2.8-19     2019-01-30 [2]
#>  Rcpp             1.0.1      2019-03-17 [2]
#>  remotes          2.0.3      2019-04-09 [2]
#>  rgdal            1.4-3      2019-03-14 [2]
#>  rlang            0.3.4      2019-04-07 [2]
#>  rmarkdown        1.12       2019-03-14 [2]
#>  rpart            4.1-13     2018-02-23 [4]
#>  rprojroot        1.3-2      2018-01-03 [2]
#>  sessioninfo      1.1.1      2018-11-05 [2]
#>  sp               1.3-1      2018-06-05 [2]
#>  spatstat         1.59-0     2019-03-22 [2]
#>  spatstat.data    1.4-0      2018-10-04 [2]
#>  spatstat.utils   1.13-0     2018-10-31 [2]
#>  stringi          1.4.3      2019-03-12 [2]
#>  stringr          1.4.0.9000 2019-02-27 [2]
#>  tensor           1.5        2012-05-05 [2]
#>  testthat         2.0.1      2018-10-13 [2]
#>  trip           * 1.5.0.9010 2019-04-13 [1]
#>  usethis          1.5.0      2019-04-07 [2]
#>  withr            2.1.2      2018-03-15 [2]
#>  xfun             0.6        2019-04-02 [2]
#>  yaml             2.2.0      2018-07-25 [2]
#>  source                            
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.0)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.3)                    
#>  Github (tidyverse/stringr@8f27b68)
#>  CRAN (R 3.5.1)                    
#>  CRAN (R 3.5.1)                    
#>  local                             
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.2)                    
#>  CRAN (R 3.5.3)                    
#>  CRAN (R 3.5.1)                    
#> 
#> [1] /perm_storage/home/mdsumner/R/x86_64-pc-linux-gnu-library/3.5
#> [2] /usr/local/lib/R/site-library
#> [3] /usr/lib/R/site-library
#> [4] /usr/lib/R/library

Created on 2019-04-13 by the reprex package (v0.2.1)

mdsumner commented 5 years ago

Oh, it's likely because sp is not attached by default now ...

mdsumner commented 5 years ago

It's working now ...