TrackerNetwork / DestinyStatus

Destiny Status code base
https://destinystatus.com
MIT License
101 stars 29 forks source link

Investigate Legacy/Private/Salvagable modes that D1 had. #80

Closed iBotPeaches closed 7 years ago

iBotPeaches commented 7 years ago

In D1 of DS we had some interesting problems

  1. Legacy - An Xbox 360 / PS3 could no longer use the site after a random Bungie update. Since the platforms for D2 are Xbox/PSN/PC, I don't imagine we will need Legacy anymore. This can be removed.

  2. Private - Accounts could make their advisors/inventory private from the public endpoints. This meant we had to survive without that data. This meant that we'd simply not show advisors and explain to the user that account is private. In D2, lets provide a link in case that user is the user searched so they can fix their settings.

  3. Salvageable - A lot of times in D1, API endpoints would just stop working. This was advisors, xur, progress and more. The problem is the entire profile died because this wasn't available. We introduced something known as salvagable, which would allow the request to fail and just skip that data from the view. The only request that wasn't salvagable was the main profile request.

iBotPeaches commented 7 years ago

This is done. Removed Legacy, support for Private/Salvageable still exists.