TracksApp / tracks

Tracks is a GTD™ web application, built with Ruby on Rails
https://www.getontracks.org/
GNU General Public License v2.0
1.17k stars 537 forks source link

Repeating Todo is marked as completed #1444

Closed dnrce closed 9 years ago

dnrce commented 10 years ago

Migrated from the original issue at https://www.assembla.com/spaces/tracks-tickets/tickets/1444

I have three repeating daily todos that I sometimes tick off at roughly the same time. While my server takes some seconds to work on these tasks, eventually all three tasks are marked as done (as intended). However, sometimes one of those underlying repeating todos is also marked as completed.

I do not know why this happens, but I am sure that a repeating todos hould not be marked as completed when just dealing with instances of the task.

Of course, the repeating todo is not limited in any way, so it should continue forever.

Originally reported by carsten.otto on August 8, 2013 at 20:13:29 (+0100) against version 2.2.2

dnrce commented 10 years ago

On September 9, 2013 at 09:56:02 (+0100), lrbalt commented:

are there two or more todos that somehow belong to the same repeat pattern?

dnrce commented 10 years ago

On September 9, 2013 at 10:30:26 (+0100), carsten.otto commented:

Yes, I have "do X in the morning", "do X at noon", "do X in the evening". Sometimes I mark all of them as completed at the same time (for example when I come home late at night, but I did X at the times mentioned). All of these three repeating todos have the same pattern and details (apart from the description): repeat daily.

dnrce commented 10 years ago

On January 1, 2014 at 15:21:58 (+0000), lrbalt commented:

I was looking onto your report. A recurring todo is marked complete if Tracks thinks there is no new todo necessary for this recurring todo. That can happen:

Perhaps there is a corner case on the dates. Do you set the due date and/or the show_from date?

C-Otto commented 10 years ago

No, I did not set an end date, nor a limit of repetitions.

dnrce commented 10 years ago

Is this an issue with the master branch, too?

C-Otto commented 10 years ago

I still need to test this using PostgreSQL and the slow-ish server. I failed to reproduce this locally (with master, sqlite3, faster PC). Investigating this is on my todo list :)

dnrce commented 10 years ago

@C-Otto Have you had luck reproducing this?

C-Otto commented 10 years ago

No, not yet. I still have an eye on this, though.

dnrce commented 10 years ago

@C-Otto We're very close to getting 2.2.3 out the door. Think you'll have a chance to look at this soon?

C-Otto commented 10 years ago

I'm looking at it whenever I use my tracks installation. So far I was unable to reproduce the problem, even if I tried hard. So I guess this issue is resolved, but I can't be sure about that.

dnrce commented 10 years ago

Thanks. What version are you running day-to-day?

C-Otto commented 10 years ago

A very recent master commit.

dnrce commented 10 years ago

Oh. This was reported against the 2.2 branch.

lrbalt commented 9 years ago

closing this one. This is fixed in master and Carsten is running master, so problem "solved" :-)