Tag filter confuses todo and recurring todo - Githubissues

TracksApp / tracks

Tracks is a GTD™ web application, built with Ruby on Rails

https://www.getontracks.org/

GNU General Public License v2.0

1.17k stars 537 forks source link

Tag filter confuses todo and recurring todo #1724

Closed C-Otto closed 9 years ago

C-Otto commented 9 years ago

On https://xxx/tracks/todos/tag/yyy# I see two entries for my tag named yyy. The first is correct, which is a repeating todo. It's ID is 4130, and the corresponding pattern is in the recurring_todos table with ID 110.

Below this (correct) entry I also see the wrong entry, which is a normal task with ID 110. It seems tracks does not use the taggable_type column when finding todos with a specific tag.

dnrce commented 9 years ago

Needs to be backported to 2.3

matjack1 commented 9 years ago

Do you mean add the commit to the 2.3 branch? Do I need to open another PR for that?

dnrce commented 9 years ago

Nah, I'll take care of it. Thanks.

matjack1 commented 9 years ago

:cool: