search

Tracktion / choc

A collection of header only classes, permissively licensed, to provide basic useful tasks with the bare-minimum of dependencies.
Other
540 stars 49 forks source link

Cleanup string trimming loops #27

Closed movatica closed 1 year ago

movatica commented 1 year ago

Refactored some of the loops to make the functions shorter and more readable.

movatica commented 1 year ago

Sorry you think that way, other library maintainers certainly don't, so while I get your point, please don't generalize your opinion.

The One-Line-If is not my style, but common in the whole file, so I stuck with that to actually blend in, don't blame me for that.

julianstorer commented 1 year ago

Well.. it's true that most library maintainers are more diplomatic than me :) (..at least in public!)

We do try to respectfully discourage PRs in general: https://github.com/Tracktion/choc/blob/main/CONTRIBUTING.md

FYI, our rules on the one-line-if is that we allow it where there are consecutive lines which are lined-up vertically to highlight similarities between the lines, so I guess that's where you would have seen it.