search

Tracktion / tracktion_engine

Tracktion Engine module
Other
1.16k stars 148 forks source link

EqualizerPlugin.cpp lines 71->73 and 83->85 say 'High/Low-pass' when they should say 'High/Low-shelf' #116

Closed jamierpond closed 2 years ago

jamierpond commented 2 years ago

Hey guys, I think there are some typos in the Equalizer plugin cpp file. I think they are minor ones, but it changes the meaning of the label quite a lot!

Currently:

addAutomatableParameter (hiFreq = new EQAutomatableParameter (*this, "High-pass freq", TRANS("High-shelf freq"), *this, {

Should be:

addAutomatableParameter (hiFreq = new EQAutomatableParameter (*this, "High-**shelf** freq", TRANS("High-shelf freq"), *this, {
drowaudio commented 2 years ago

Yeah maybe that would be a better name but it can't be changed now as that's the property the model references and is stored in the XML file. If we changed it, all existing sessions would break and it's not significant enough a change to add the the edit conversion pass (which would break minor version backwards compatibility which we rely on for testing).

jamierpond commented 2 years ago

Oh damn, I see! Sorry I didn't see this before the PR. That makes sense. Would be cool to find a solution for this at some point!