Closed stonepreston closed 2 years ago
Thanks for the fix! Yes I think true is correct in this case as rpallocator is a singleton so should be able to handle the allocations between different types (and it works on raw pointers). https://github.com/Tracktion/tracktion_engine/commit/edd6fb6b0e23aad25463ee2425d8ec9c9d38d918
3 files ±0 3 suites ±0 0s :stopwatch: ±0s 152 tests ±0 152 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 5 778 runs ±0 5 778 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit edd6fb6b. ± Comparison against base commit 48e837ae.
0 files ±0 0 suites ±0 0s :stopwatch: ±0s 0 tests ±0 0 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit edd6fb6b. ± Comparison against base commit 48e837ae.
Currently the engine is unable to be built using newer compilers/stdlibs such as GCC 11.2.0 and clang 14 (which are what is available in the newest LTS of Ubuntu 22.04). The compiler error is listed below:
The fix for this is to define operators for
==
and!=
. The docs have this to say about==
I have returned true for == in this PR, but i dont know enough about these allocators to say whether or not storage allocated by one can be deallocated by another. Hopefully you can provide some guidance as to what the desired behavior is for the allocator.
The fix does work, and I can confirm the engine compiles on GCC 11.2.0 and clang 14