search

Tracktion / tracktion_engine

Tracktion Engine module
Other
1.16k stars 148 forks source link

Pause if updating prepared node #129

Closed jamierpond closed 1 year ago

jamierpond commented 1 year ago

There seems to be some checks for this at the top of this function, but this doesn't really seem to be all that robust, as we still get crashes there, this just adds in more checks. I haven't been able to hit any crashes with these changes in conjuction with the other ScopedReallocationInhibitor.

drowaudio commented 1 year ago

I'm not sure what the status of this PR is but I think the original issue might be fixed by some refactoring I was doing in this PR: https://github.com/Tracktion/tracktion_engine/pull/127

Most notably I've introduced a LockFreeObject class in to LockFreeMultiThreadedNodePlayer which should avoid these issues and clean the code up a bit.