search

Tracktion / tracktion_engine

Tracktion Engine module
Other
1.2k stars 152 forks source link

MidiNode: Fixed a couple of loops and assertions regarding the range channelNumbers end #155

Closed svenemtell closed 1 year ago

svenemtell commented 1 year ago

See discussion here: [MidiNode channelNumbers range?]

drowaudio commented 1 year ago

Thanks. I think it's probably cleaner for the for loops to be written as for (int i = channelNumbers.getStart(); i < channelNumbers.getEnd(); ++i) As that more clearly maps on to the inclusive start/exclusive end?

svenemtell commented 1 year ago

Sounds good! I fixed the loops (but left the assertions) and updated the headline of the PR.

drowaudio commented 1 year ago

Should be fixed here now: https://github.com/Tracktion/tracktion_engine/commit/ac5fa7ce9cf19807ea12b3a89d36ce7706f90b64

github-actions[bot] commented 1 year ago

Unit Test Results

       3 files  ±0         3 suites  ±0   0s :stopwatch: ±0s    169 tests ±0     169 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  6 186 runs  ±0  6 186 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit ac5fa7ce. ± Comparison against base commit 447a5d54.

github-actions[bot] commented 1 year ago

Performance Test Results

0 files  ±0  0 suites  ±0   0s :stopwatch: ±0s 0 tests ±0  0 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit ac5fa7ce. ± Comparison against base commit 447a5d54.